Skip to content

Convert all projects to .NET Core 3.1#3

Open
Ryan-Myers wants to merge 2 commits intoNanook:masterfrom
Ryan-Myers:master
Open

Convert all projects to .NET Core 3.1#3
Ryan-Myers wants to merge 2 commits intoNanook:masterfrom
Ryan-Myers:master

Conversation

@Ryan-Myers
Copy link

This hasn't been thoroughly validated yet, especially your reference to a modified SharpCompress library since I couldn't find out which lines were modified. Everything does compile though, and I'll be putting it through it's paces soon enough. I wanted to use this on an ARM Linux box, which is why it needed to be Core.

@Ryan-Myers
Copy link
Author

Just a quick update. I've successfully compiled ConvertToNkit for ARM on Linux, and tested it with Animal Crossing GC. The compile command was:
dotnet build --runtime debian.10-arm

The output summary from the test is:
TimeStamp Conversion System ReadResult OutputResult OutputCrc OutputID4 RedumpMatch RedumpName InputSize OutputSize FullSize InputFilename OutputFilename MD5 SHA1 Passes SecondsElapsed ErrorMessage 03/02/2020 11:38:22 ConvertToNKit GameCube VerifySuccess VerifySuccess 7BE72542 GAFE Redump Animal Crossing (USA) 1459978240 17215303 1459978240 /media/usb_drive/NKit-Arm/Animal Crossing (USA).iso /media/usb_drive/NKit-Arm/Processed/GameCube/Animal Crossing (USA).nkit.gcz 27714D8994354B301B4EAB8425FF66B8 EBB6E3B0DEA1303E1B13A700A5A02D0F5BBDF80B 4 Passes: [ISO] >> [1:To NKit] >> [2:To GCZ] >> [3:Calc Hashes] >> [4:NKit Verify] 104

@Ryan-Myers
Copy link
Author

@beyondmeat
Copy link

Well I guess it's time to update .net 6 now

@cgarz
Copy link

cgarz commented Feb 20, 2022

I notice that the crc is 00000000. Is it the same on winblows? Any ideas as to why?
I mentioned that's what I keep getting in #5. Was hoping the net core upgrade might fix it.

@Ryan-Myers
Copy link
Author

Not sure, never noticed it has 0 for the CRC. Though if you look at the line for verification it actually does have a value. Haven't looked at this in over 2 years though. This did work for me to convert all games to nkit with verification though, which is what I needed it to do.

@cgarz
Copy link

cgarz commented Feb 20, 2022

Had a chance to test it out now but looks like the issue from #5 unfortunately persists. I even included PR #14 in case that might help.
When you were converting to NKit did you have it set to remove partitions?
If I set it to keep them it works fine just like NKit 1.4 in mono.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants