Add Warriors of Rock DLC support and bug fixes#2
Open
jasonulbright wants to merge 2 commits intoNanook:upgrade-to-NET10from
Open
Add Warriors of Rock DLC support and bug fixes#2jasonulbright wants to merge 2 commits intoNanook:upgrade-to-NET10from
jasonulbright wants to merge 2 commits intoNanook:upgrade-to-NET10from
Conversation
- Handle duplicate CRC-based filenames in PAK headers (WoR DLC has multiple .qs files sharing the same CRC hash). Suffixes _2, _3, etc. are appended to disambiguate. - Fix inverted path length checks in ScriptEditor and SimpleArrayEditor export/import dialogs (== 0 should be != 0). - Fix QbKey.GetHashCode() to be consistent with Equals() - was using base.GetHashCode() & crc, now returns crc.GetHashCode(). - Fix PAK file extraction using ReadWrite access instead of Read. - Fix undisposed BinaryReader/BinaryWriter in copyData (leaveOpen: true). - Fix undisposed BinaryEndianWriter in QbFile.Write (add leaveOpen ctor). - Add comment noting uint < 0 is always false in QbItemBase validation. - Simplify QueenBeeParser to single net10.0 target framework. - Widen Information dialog to prevent text wrapping. - Update About tab and Version History (v1.9) with all changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The zlib source files (12 .cs files in QueenBeeParser/Zlib/) are already compiled by QueenBeeParser.csproj via SDK-style auto-inclusion. The old zlib.net.csproj (pre-SDK Visual Studio 2008 format) and zlib.net.sln were orphaned artifacts that cause parse errors in modern IDEs (VS Code C# extension, MSBuild). Removing them eliminates the IDE errors with no functional change -- the build output is identical before and after. The zlib source code and license.txt are preserved. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.qsfiles all sharing CRC99D6564D) now load without error — duplicates are suffixed_2,_3, etc.QbKey.GetHashCode()inconsistent withEquals(), unnecessaryReadWritefile access during extraction, undisposed streams incopyDataandQbFile.Writenet10.0target (multi-target required SDKs not typically installed)Files changed (10)
PakEditor.csReadWrite→Read,leaveOpenstreamsQbKey.csGetHashCode()returns_crc.GetHashCode()QbFile.csusingblock withleaveOpen: trueQbItemBase.csuint < 0dead validationBinaryEndianWriter.csleaveOpenconstructor overloadScriptEditor.cs== 0→!= 0onLastScriptPath.LengthSimpleArrayEditor.cs== 0→!= 0onLastArrayPath.LengthQueenBeeParser.csprojnet10.0targetInfoForm.csInfoForm.Designer.csTesting
Tested with WoR DLC PAK files extracted from STFS containers:
bdlc747_song.pak.xen— 39 QB items, full tree expansion ✓cdl481.pak.xen— catalog file ✓cmanifest_dlc747.pak.xen— manifest file ✓cdl481_text.pak.xen— localized text with duplicate CRCs ✓All 4 PAK types from 130 extracted WoR DLC files loaded successfully.
🤖 Generated with Claude Code