Cleanout UtilityRoutines

idd/Energy+.idd.in

@@ -85606,10 +85606,10 @@ PlantEquipmentOperationSchemes,
        \memo Only plant equipment should be listed on a Control Scheme for this item.
        \min-fields 4
   A1 , \field Name
-        \required-field
+       \required-field
        \reference PlantOperationSchemes
   A2 , \field Control Scheme 1 Object Type
-        \required-field
+       \required-field
        \type choice
        \key PlantEquipmentOperation:CoolingLoad
        \key PlantEquipmentOperation:HeatingLoad
@@ -92227,6 +92227,7 @@ PhotovoltaicPerformance:Simple,
         \memo which surfaces convert incident solar radiation to electricity and need not specify
         \memo arrays of specific modules.
    A1 , \field Name
+        \required-field
         \reference PVModules
    N1 , \field Fraction of Surface Area with Active Solar Cells
         \required-field
@@ -92252,6 +92253,7 @@ PhotovoltaicPerformance:EquivalentOne-Diode,
         \memo using an equivalent one-diode circuit. This model is also known as
         \memo the 4- or 5-parameter TRNSYS model for photovoltaics.
    A1 , \field Name
+        \required-field
         \reference PVModules
    A2 , \field Cell type
         \type choice
@@ -92362,6 +92364,7 @@ PhotovoltaicPerformance:Sandia,
         \memo Describes performance input data needed for specific makes and models of production
         \memo PV panels using the empirical coefficients assembled by Sandia National Laboratory.
    A1 , \field Name
+        \required-field
         \reference PVModules
    N1 , \field Active Area
         \note (m2, single module)

src/EnergyPlus/ExternalInterface.cc

@@ -1230,18 +1230,6 @@ void InitExternalInterfaceFMUImport(EnergyPlusData &state)
                                                                  cCurrentModuleObject,
                                                                  fmuInst.Name,
                                                                  state.dataExternalInterface->ErrorsFound);
-                        //                            Util::VerifyName( state.dataExternalInterface->FMU( i ).Instance( j
-                        //                            ).fmuInputVariable(
-                        // k
-                        //).Name,  state.dataExternalInterface->FMU(
-                        // i
-                        //).Instance(
-                        // j
-                        //).checkfmuInputVariable, NumFMUInputVariables, IsNotOK, IsBlank, "The FMU input variable \"" +
-                        // state.dataExternalInterface->FMU( i ).Instance( j
-                        //).fmuInputVariable( k ).Name + "\" of instance \"" + state.dataExternalInterface->FMU( i ).Instance( j ).Name + "\" of FMU
-                        //\"" + state.dataExternalInterface->FMU( i ).Name + "\"
-                        // has duplicates. Please check the input file again and delete duplicated entries." );
                         if (state.dataExternalInterface->ErrorsFound) {
                             StopExternalInterfaceIfError(state);
                         } else {

src/EnergyPlus/GeneralRoutines.cc

@@ -196,7 +196,7 @@ void ControlCompOutput(EnergyPlusData &state,
     if (ControlCompTypeNum != 0) {
         SimCompNum = ControlCompTypeNum;
     } else {
-        SimCompNum = Util::FindItemInSortedList(CompType, ListOfComponents, NumComponents);
+        SimCompNum = Util::FindItem(CompType, ListOfComponents, NumComponents);
         ControlCompTypeNum = SimCompNum;
     }
 

src/EnergyPlus/HVACSingleDuctInduc.cc

@@ -249,7 +249,6 @@ namespace HVACSingleDuctInduc {
             ErrorObjectHeader eoh{routineName, CurrentModuleObject, Alphas(1)};
 
             int IUNum = IUIndex;
-            Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound);
 
             state.dataHVACSingleDuctInduc->IndUnit(IUNum).Name = Alphas(1);
             state.dataHVACSingleDuctInduc->IndUnit(IUNum).UnitType = CurrentModuleObject;

src/EnergyPlus/HVACVariableRefrigerantFlow.cc

@@ -1572,7 +1572,6 @@ void GetVRFInputData(EnergyPlusData &state, bool &ErrorsFound)
                                                                  lAlphaFieldBlanks,
                                                                  cAlphaFieldNames,
                                                                  cNumericFieldNames);
-        Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound);
 
         auto &thisTUList = state.dataHVACVarRefFlow->TerminalUnitList(TUListNum);
         thisTUList.Name = cAlphaArgs(1);
@@ -3347,7 +3346,6 @@ void GetVRFInputData(EnergyPlusData &state, bool &ErrorsFound)
 
         state.dataHVACVarRefFlow->VRFTUNumericFields(VRFTUNum).FieldNames.allocate(NumNums);
         state.dataHVACVarRefFlow->VRFTUNumericFields(VRFTUNum).FieldNames = cNumericFieldNames;
-        Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound);
 
         auto &thisVrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
         thisVrfTU.Name = cAlphaArgs(1);

src/EnergyPlus/HeatBalanceManager.cc

@@ -1883,10 +1883,6 @@ namespace HeatBalanceManager {
                 TMP = index(state.dataIPShortCut->cAlphaArgs(1), char(2));
             }
 
-            if (Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataHeatBalMgr->CurrentModuleObject, ErrorsFound)) {
-                continue;
-            }
-
             ++ZoneLoop;
             ProcessZoneData(state,
                             cCurrentModuleObject,

src/EnergyPlus/HybridUnitaryAirConditioners.cc

@@ -497,16 +497,6 @@ void GetInputZoneHybridUnitaryAirConditioners(EnergyPlusData &state, bool &Error
                                                                      cAlphaFields,
                                                                      cNumericFields);
 
-            bool IsNotOK = false;
-            bool IsBlank = false;
-            Util::VerifyName(state,
-                             Alphas(1),
-                             state.dataHybridUnitaryAC->ZoneHybridUnitaryAirConditioner,
-                             UnitLoop - 1,
-                             IsNotOK,
-                             IsBlank,
-                             cCurrentModuleObject + " Name");
-
             ErrorObjectHeader eoh{routineName, cCurrentModuleObject, Alphas(1)};
             auto &hybridUnitaryAC = state.dataHybridUnitaryAC->ZoneHybridUnitaryAirConditioner(UnitLoop);
 

src/EnergyPlus/IceThermalStorage.cc

@@ -738,7 +738,6 @@ namespace IceThermalStorage {
                                                                      _,
                                                                      _,
                                                                      state.dataIPShortCut->cNumericFieldNames);
-            Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound);
 
             state.dataIceThermalStorage->ThermalStorageSizing(sizingNum).name = state.dataIPShortCut->cAlphaArgs(1);
             state.dataIceThermalStorage->ThermalStorageSizing(sizingNum).onPeakStart = state.dataIPShortCut->rNumericArgs(1);
@@ -779,7 +778,6 @@ namespace IceThermalStorage {
                                                                      state.dataIPShortCut->lAlphaFieldBlanks,
                                                                      state.dataIPShortCut->cAlphaFieldNames,
                                                                      state.dataIPShortCut->cNumericFieldNames);
-            Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound);
 
             ++state.dataIceThermalStorage->TotalNumIceStorage;
             state.dataIceThermalStorage->SimpleIceStorage(iceNum).MapNum = state.dataIceThermalStorage->TotalNumIceStorage;
@@ -905,8 +903,6 @@ namespace IceThermalStorage {
 
             ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)};
 
-            Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound);
-
             ++state.dataIceThermalStorage->TotalNumIceStorage;
 
             state.dataIceThermalStorage->DetailedIceStorage(iceNum).MapNum = state.dataIceThermalStorage->TotalNumIceStorage;

src/EnergyPlus/IndoorGreen.cc

@@ -137,7 +137,6 @@ namespace IndoorGreen {
                                 s_ipsc->cAlphaFieldNames,
                                 s_ipsc->cNumericFieldNames);
             ErrorObjectHeader eoh{RoutineName, cCurrentModuleObject, s_ipsc->cAlphaArgs(1)};
-            Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound);
             ig.Name = s_ipsc->cAlphaArgs(1);
             ig.SurfName = s_ipsc->cAlphaArgs(2);
             ig.SurfPtr = Util::FindItemInList(s_ipsc->cAlphaArgs(2), state.dataSurface->Surface);

src/EnergyPlus/InternalHeatGains.cc

@@ -2565,7 +2565,6 @@ namespace InternalHeatGains {
                                                                      IHGNumericFieldNames);
 
             ErrorObjectHeader eoh{routineName, contamSSModuleObject, IHGAlphas(1)};
-            Util::IsNameEmpty(state, IHGAlphas(1), contamSSModuleObject, ErrorsFound);
 
             state.dataHeatBal->ZoneCO2Gen(Loop).Name = IHGAlphas(1);
 

src/EnergyPlus/MatrixDataManager.cc

@@ -148,7 +148,6 @@ namespace MatrixDataManager {
                                                                      state.dataIPShortCut->cAlphaFieldNames,
                                                                      state.dataIPShortCut->cNumericFieldNames);
             ++MatNum;
-            Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound);
 
             state.dataMatrixDataManager->MatData(MatNum).Name = state.dataIPShortCut->cAlphaArgs(1);
             int NumRows = std::floor(state.dataIPShortCut->rNumericArgs(1));

src/EnergyPlus/MicroturbineElectricGenerator.cc

@@ -159,7 +159,7 @@ void GetMTGeneratorInput(EnergyPlusData &state)
                                                                  state.dataIPShortCut->lAlphaFieldBlanks,
                                                                  state.dataIPShortCut->cAlphaFieldNames,
                                                                  state.dataIPShortCut->cNumericFieldNames);
-        Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound);
+
         state.dataMircoturbElectGen->MTGenerator(GeneratorNum).Name = AlphArray(1);
 
         state.dataMircoturbElectGen->MTGenerator(GeneratorNum).RefElecPowerOutput = NumArray(1);

src/EnergyPlus/MixerComponent.cc

@@ -216,7 +216,6 @@ void GetMixerInput(EnergyPlusData &state)
                                                                  lAlphaBlanks,
                                                                  cAlphaFields,
                                                                  cNumericFields);
-        Util::IsNameEmpty(state, AlphArray(1), CurrentModuleObject, ErrorsFound);
 
         state.dataMixerComponent->MixerCond(MixerNum).MixerName = AlphArray(1);
 

src/EnergyPlus/NodeInputManager.cc

@@ -559,9 +559,6 @@ void GetNodeListsInput(EnergyPlusData &state, bool &ErrorsFound) // Set to true
     for (int Loop = 1; Loop <= state.dataNodeInputMgr->NumOfNodeLists; ++Loop) {
         state.dataInputProcessing->inputProcessor->getObjectItem(
             state, CurrentModuleObject, Loop, cAlphas, NumAlphas, rNumbers, NumNumbers, IOStatus);
-        if (Util::IsNameEmpty(state, cAlphas(1), CurrentModuleObject, localErrorsFound)) {
-            continue;
-        }
 
         ++NCount;
         state.dataNodeInputMgr->NodeLists(NCount).Name = cAlphas(1);

src/EnergyPlus/OutdoorAirUnit.cc

@@ -306,7 +306,6 @@ namespace OutdoorAirUnit {
                                                                      cNumericFields);
 
             ErrorObjectHeader eoh{routineName, CurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)};
-            Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), CurrentModuleObject, ErrorsFound);
 
             // A1
             thisOutAirUnit.Name = state.dataIPShortCut->cAlphaArgs(1);

src/EnergyPlus/OutputReportTabular.cc

@@ -371,20 +371,17 @@ void GetInputTabularMonthly(EnergyPlusData &state)
     Array1D_string AlphArray; // character string data
     Array1D<Real64> NumArray; // numeric data
     int IOStat = -1;          // IO Status when calling get input subroutine
-    bool ErrorsFound = false;
 
     state.dataInputProcessing->inputProcessor->getObjectDefMaxArgs(state, CurrentModuleObject, NumParams, NumAlphas, NumNums);
     AlphArray.allocate(NumAlphas);
     NumArray.dimension(NumNums, 0.0);
     for (int TabNum = 1, TabNum_end = ort->MonthlyInputCount; TabNum <= TabNum_end; ++TabNum) { // MonthlyInputCount is modified in the loop
         state.dataInputProcessing->inputProcessor->getObjectItem(state, CurrentModuleObject, TabNum, AlphArray, NumAlphas, NumArray, NumNums, IOStat);
 
-        if (TabNum - 1 > 0) {
-            Util::IsNameEmpty(state, AlphArray(1), CurrentModuleObject, ErrorsFound);
-        }
         if (NumAlphas < 2) {
             ShowSevereError(state, EnergyPlus::format("{}: No fields specified.", CurrentModuleObject));
         }
+
         // add to the data structure
         int const curTable = AddMonthlyReport(state, AlphArray(1), int(NumArray(1)));
         for (int jField = 2; jField <= NumAlphas; jField += 2) {

src/EnergyPlus/PCMThermalStorage.cc

@@ -509,8 +509,6 @@ namespace PCMStorage {
                                                                  state.dataIPShortCut->cAlphaFieldNames,
                                                                  state.dataIPShortCut->cNumericFieldNames);
 
-        Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound);
-
         PCM.Name = state.dataIPShortCut->cAlphaArgs(1);
         PCM.AvailabilityScheduleName = state.dataIPShortCut->cAlphaArgs(2);
 

src/EnergyPlus/PackagedThermalStorageCoil.cc

@@ -240,8 +240,6 @@ void GetTESCoilInput(EnergyPlusData &state)
 
         ErrorObjectHeader eoh{routineName, cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)};
 
-        Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound);
-
         // ErrorsFound will be set to True if problem was found, left untouched otherwise
         VerifyUniqueCoilName(state, cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1), ErrorsFound, cCurrentModuleObject + " Name");
 

src/EnergyPlus/Photovoltaics.cc

@@ -333,7 +333,6 @@ namespace Photovoltaics {
 
             ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)};
 
-            Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound);
             state.dataPhotovoltaic->PVarray(PVnum).Name = s_ipsc->cAlphaArgs(1);
 
             state.dataPhotovoltaic->PVarray(PVnum).SurfaceName = s_ipsc->cAlphaArgs(2);
@@ -477,9 +476,6 @@ namespace Photovoltaics {
 
                 ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)};
 
-                if (Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound)) {
-                    continue;
-                }
                 tmpSimpleModuleParams(ModNum).Name = s_ipsc->cAlphaArgs(1);
                 tmpSimpleModuleParams(ModNum).ActiveFraction = s_ipsc->rNumericArgs(1);
 
@@ -523,9 +519,7 @@ namespace Photovoltaics {
                                                                          s_ipsc->cNumericFieldNames);
 
                 ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)};
-                if (Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound)) {
-                    continue;
-                }
+
                 tmpTRNSYSModuleParams(ModNum).Name = s_ipsc->cAlphaArgs(1);
 
                 if (s_ipsc->lAlphaFieldBlanks(2)) {
@@ -575,9 +569,6 @@ namespace Photovoltaics {
                                                                          s_ipsc->lAlphaFieldBlanks,
                                                                          s_ipsc->cAlphaFieldNames,
                                                                          s_ipsc->cNumericFieldNames);
-                if (Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound)) {
-                    continue;
-                }
 
                 tmpSNLModuleParams(ModNum).name = s_ipsc->cAlphaArgs(1);
                 tmpSNLModuleParams(ModNum).Acoll = s_ipsc->rNumericArgs(1);

src/EnergyPlus/Plant/PlantManager.cc

@@ -389,7 +389,6 @@ void GetPlantLoopData(EnergyPlusData &state)
             eoh.objectName = Alpha(1);
         }
 
-        Util::IsNameEmpty(state, Alpha(1), CurrentModuleObject, ErrorsFound);
         this_loop.Name = Alpha(1); // Load the Plant Loop Name
 
         if (Util::SameString(Alpha(2), "STEAM")) {

src/EnergyPlus/PlantCentralGSHP.cc

@@ -593,11 +593,6 @@ void GetWrapperInput(EnergyPlusData &state)
 
         state.dataPlantCentralGSHP->Wrapper(WrapperNum).Name = state.dataIPShortCut->cAlphaArgs(1);
 
-        // initialize nth chiller heater index (including identical units) for current wrapper
-        if (Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound)) {
-            continue;
-        }
-
         if (state.dataIPShortCut->cAlphaArgs(2) == "SMARTMIXING") {
             state.dataPlantCentralGSHP->Wrapper(WrapperNum).ControlMode = CondenserType::SmartMixing;
         }
@@ -1214,7 +1209,6 @@ void GetChillerHeaterInput(EnergyPlusData &state)
                                                                  state.dataIPShortCut->cNumericFieldNames);
 
         state.dataPlantCentralGSHP->ChillerHeater(ChillerHeaterNum).Name = state.dataIPShortCut->cAlphaArgs(1);
-        Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, CHErrorsFound);
 
         if (Util::SameString(state.dataIPShortCut->cAlphaArgs(4), "LEAVINGCONDENSER")) {
             state.dataPlantCentralGSHP->ChillerHeater(ChillerHeaterNum).CondModeCooling = CondenserModeTemperature::LeavingCondenser;

src/EnergyPlus/PlantChillers.cc

@@ -210,8 +210,6 @@ namespace PlantChillers {
 
             ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)};
 
-            Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound);
-
             // ErrorsFound will be set to True if problem was found, left untouched otherwise
             GlobalNames::VerifyUniqueChillerName(state,
                                                  state.dataIPShortCut->cCurrentModuleObject,
@@ -2255,8 +2253,6 @@ namespace PlantChillers {
 
             ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)};
 
-            Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound);
-
             // ErrorsFound will be set to True if problem was found, left untouched otherwise
             GlobalNames::VerifyUniqueChillerName(state,
                                                  state.dataIPShortCut->cCurrentModuleObject,
@@ -4324,8 +4320,6 @@ namespace PlantChillers {
 
             ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)};
 
-            Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound);
-
             // ErrorsFound will be set to True if problem was found, left untouched otherwise
             GlobalNames::VerifyUniqueChillerName(state,
                                                  state.dataIPShortCut->cCurrentModuleObject,
@@ -6294,7 +6288,6 @@ namespace PlantChillers {
                                                                      state.dataIPShortCut->cNumericFieldNames);
 
             ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)};
-            Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound);
 
             // ErrorsFound will be set to True if problem was found, left untouched otherwise
             GlobalNames::VerifyUniqueChillerName(state,