-
Notifications
You must be signed in to change notification settings - Fork 467
Relax leaf area index (LAI) range for the IndoorLivingWall module #11451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mitchute
merged 7 commits into
NatLabRockies:develop
from
LipingWang:IndoorGreen_Update
Mar 14, 2026
+33
−31
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c6471c7
Remove the constraint of leaf area index (LAI) for indoorlivingwall m…
LipingWang ab09e04
format update for references
LipingWang 5f8ecf4
update format for references
LipingWang 4a1de65
update format for references insert final newline
LipingWang 3bc0a8a
Clang-format
LipingWang e71d6aa
Update the limit for leaf area index
LipingWang 00374d6
I/O reference update
LipingWang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there should be some maximum. Maybe 5 or 10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comments. Currently, EnergyPlus requires that each living wall be attached to a partition wall. Relaxing the leaf area index (LAI) limit in the model can conceptually represent a larger living wall area within the space. So, users can define a relatively small partition wall, while assigning a larger LAI to represent the total leaf area present in the space. In this approach, the LAI parameter therefore represents the total leaf surface area included in the simulation, rather than the strict physical leaf area index.