Skip to content

Fix EDD and ERR output incorrectly labeled as Warmup#11578

Merged
mitchute merged 3 commits into
developfrom
edd-output-label
May 9, 2026
Merged

Fix EDD and ERR output incorrectly labeled as Warmup#11578
mitchute merged 3 commits into
developfrom
edd-output-label

Conversation

@joseph-robertson
Copy link
Copy Markdown
Collaborator

@joseph-robertson joseph-robertson commented May 5, 2026

Pull request overview

  • Fixes EDD output incorrectly labeled as Warmup #11550
  • Expected changes:
    • "During Warmup & Sizing" -> "During Setup & Sizing" (e.g., 2ZoneDataCenterHVAC_wEconomizer.idf)
    • "During Warmup" -> "During Setup" (e.g., 1ZoneDataCenterCRAC_wApproachTemp.idf)
image

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@joseph-robertson joseph-robertson self-assigned this May 5, 2026
@joseph-robertson joseph-robertson added the Defect Includes code to repair a defect in EnergyPlus label May 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

⚠️ Regressions detected on macos-14 for commit b3786e0

Regression Summary
  • EDD: 18
  • ERR: 12

@joseph-robertson joseph-robertson changed the title Fix EDD output incorrectly labeled as Warmup Fix EDD and ERR output incorrectly labeled as Warmup May 6, 2026
@joseph-robertson joseph-robertson marked this pull request as ready for review May 6, 2026 22:09
@NatLabRockies NatLabRockies deleted a comment from github-actions Bot May 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

⚠️ Regressions detected on macos-14 for commit ab73c90

Regression Summary
  • EDD: 18
  • ERR: 12

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit ab73c90

Regression Summary
  • EDD: 19
  • ERR: 12

Copy link
Copy Markdown
Collaborator

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joseph-robertson. This is all cleaned up now and consistent.

@mitchute mitchute merged commit 74e4b5b into develop May 9, 2026
11 checks passed
@mitchute mitchute deleted the edd-output-label branch May 9, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EDD output incorrectly labeled as Warmup

3 participants