-
Notifications
You must be signed in to change notification settings - Fork 34
Bnb/cond obs fwp #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bnb/cond obs fwp #262
Changes from 111 commits
Commits
Show all changes
122 commits
Select commit
Hold shift + click to select a range
c65ce52
dual sampler, queue, and batch handler with obs. modifying Sup3rDatas…
bnb32 16ca65c
training with obs test
bnb32 8630629
split up interface and abstact model
bnb32 9e35ce0
made dual batch queue flexible enough to account for additional obs m…
bnb32 7c52bf5
tensorboard mixin moved to model utilities. dual queue completely abs…
bnb32 709792f
integrated dual sampler with obs into base dual sampler.
bnb32 019d022
examples added to DataHandler doc string. Some instructions on sup3rw…
bnb32 7ff2fba
removed namedtuple from Sup3rDataset to make Sup3rDataset picklable.
bnb32 5a483c4
parallel batch queue test added.
bnb32 53bdf46
namedtuple -> DsetTuple missing attr fix
bnb32 f25beb0
gust added to era download variables. len dunder added to ``Container…
bnb32 5e10120
computing before reshaping is 2x faster.
bnb32 f01f136
obs_index fix - sampler needs to use hr_out_features for the obs member.
bnb32 01d9e60
split up ``calc_loss`` and ``calc_loss_obs``
bnb32 507b158
Optional run_qa flag in ``DualRasterizer``. Queue shape fix for queue…
bnb32 af047da
``run_qa=True`` default for ``DualRasterizer``
bnb32 1388cd7
better tracking of batch counting. (this can be tricky for parallel q…
bnb32 950ca9e
missed compute call for slow batching. this was hidden by queueing an…
bnb32 0b489b6
Included convert to tensor in ``sample_batch``. Test for training wit…
bnb32 d7ca6cd
cc batch handler test fix
bnb32 07251bb
added test for new disc with "valid" padding
bnb32 0b1a43d
parallel sampling batch sampling test.
bnb32 81bad5c
removed workers tests. max_workers > 1 still not consistently faster.…
bnb32 ed2cc21
``Sup3rGanWithObs`` model subclass. Other misc model refactoring.
bnb32 1ee7e31
moved ``_run`` method to bias correction interface ``AbstractBiasCorr…
bnb32 e353ebc
moved ``_run`` method to bias correction interface ``AbstractBiasCorr…
bnb32 707a624
fix: tensorboard issue with loss obs details
bnb32 2816b8a
Adding obs loss to logging of loss gen
bnb32 9a30089
Adding ``loss_obs`` to ``loss_gen`` so the total loss shows in log ou…
bnb32 1a66955
generalized min pad width for padding slices so that this can accomod…
bnb32 a784290
min padding depends on the ``.paddings`` attribute of the ``FlexibleP…
bnb32 827640a
`max_paddings` method in `interface` instead of in `strategy.py`.
bnb32 a9a84c9
conditioning gan on observations with obs included through ``Sup3Fixe…
bnb32 ff4d764
simplified conditioning on obs with masked concat layer, so we don't …
bnb32 7e43ae9
Cleaned up ``Sup3rGanFixedObs`` to rely more on parent methods. Remov…
bnb32 81b3a76
removed additional gen loss term from obs loss. Need loss to be unifo…
bnb32 543a751
spatial frac uniform sampling
bnb32 e1dd305
new custom layers, which require special treatment based on naming, i…
bnb32 2f87f50
fix: epoch always started with disc_loss = 0, resulting in disc never…
bnb32 335d0b7
load check for disc training fix
bnb32 d838135
added option to add extra content loss term for obs sites, with speci…
bnb32 8d519e1
added gen loss to previous epoch details, as part of running means
bnb32 8639ff9
Using running dataframe records of training and validation batch loss…
bnb32 ad0ef04
use index to append loss details record
bnb32 5e055eb
changed trained_frac naming - doesn't make sense to prefix these with…
bnb32 ecbde08
added `loss_mean_window` arg, material derivative loss with extremes,…
bnb32 8fa47f0
material derivative loss test fix
bnb32 13a8fe0
typo
bnb32 e145aaa
removing bespoke multi term loss functions which can now be created b…
bnb32 bed8609
Removing old loss functions in tests
bnb32 ab2f4e4
adding obs loss to gen content in loss details
bnb32 ec54317
gen_loss_content functions now return total loss value and dictionary…
bnb32 5a83f55
Starting fwp integration of conditional obs models
bnb32 c9606de
test fixes and missed function rename
bnb32 7aa6339
fix: multi-term loss for dc models and multiterm loss test
bnb32 afda2b9
``min_width`` as optional kwarg instead of determined from generator …
bnb32 5758a97
renaming `_get_batch_loss_details`. moved weight into to start of `tr…
bnb32 a31163d
don't need this `max_paddings` method since `min_width` is a user arg…
bnb32 78eaacf
`if not self.generator_weights` condition added to obs model `init_we…
bnb32 3c703bf
Removing `Sup3rGanWithObs` model. Keeping just `Sup3rGanFixedObs` mod…
bnb32 e0968ea
Removing tf.function decorator from some top level functions to preve…
bnb32 b806691
Removing unused experimental layers: `Sup3rImpute`, `Sup3rConcatObsBl…
bnb32 7dc4e40
Added relativistic discriminator loss used in ESRGAN paper.
bnb32 020278d
Concatenating less / more realistic terms to get "mean" - disc gettin…
bnb32 57a5c4f
Changed `Sup3rGanFixedObs` to Sup3rGanWithObs`
bnb32 e99d7d8
Initial commit with `ObsRasterizer` for integrating sparse observatio…
bnb32 8130f52
moved `obs_features` to interface to use base `init_weights` method. …
bnb32 bff8b71
Clipped negative lower limit for observation mask sampling. Era downl…
bnb32 dbae7ff
xarray future warning - changed ds.dims to ds.sizes
bnb32 f01d8b4
example notebook for running sup3rwind models. added skin temp to era…
bnb32 2c534c6
lin interp threshold - was previously getting excessively large wind …
bnb32 901baa0
Combined ExoRasterizerNC / H5. Added functionality for 3d regridding …
bnb32 29231ca
Added some preproc to xr_open_mfdataset for handling problematic era …
bnb32 5eec440
Added check for correct number of model outputs
bnb32 7b68f16
Adding time index to coords of 3d exo data
bnb32 c5c6078
simpler running sup3r models notebook
bnb32 925f448
netcdf version cap comment in pyproject.toml
bnb32 fd0ac66
dont need to copy inputs in np.meshgrid. set copy=False in `get_lat_lon`
bnb32 6310777
reverting netcdf version cap
bnb32 2f14707
numpy < 2.0 - need this to use modules compiled with np 1.x
bnb32 6126d3e
Update pyproject.toml
bnb32 8050d1d
time dependent lat / lon features - need the time dimension for dual …
bnb32 9bd96bf
updated sup3rwind example readme with example notebook.
bnb32 889f01c
Added `compute_disc` to solar model `calc_loss`. Split up the sub day…
bnb32 0d4f681
fix: wasn't updating batch loss details correctly when both disc and …
bnb32 29d15a9
NaN checks for fwp input and output and some QOL adds.
bnb32 ac96bd1
add some log info on output values outside of good range.
bnb32 07b86ea
feat: add nn_fill option to handle data outside limits in forward pas…
bnb32 543f464
refactor: update nn_fill_array import path and remove unused function…
bnb32 d676594
feat: enabled forward passes with obs models to run without obs data;…
bnb32 489b2f7
refactor: remove weighted observation layers and update related confi…
bnb32 f628a91
feat: enhance output handling by ensuring float32 data type for lat/l…
bnb32 33e4305
fix: remove duplicate compute_disc parameter in SolarCC class constru…
bnb32 c37619f
Update pyproject.toml
bnb32 2f9ec3f
fix: only compute obs loss calc when training the generator; typo in …
bnb32 fbcb039
more robust height interpolation which uses lower and higher levels i…
bnb32 1f57348
Interp method to use closest levels if there are no levels lower or h…
bnb32 1de8cb3
remove redundant calcs in Sup3rGanDC val loss
bnb32 78c1987
feat: previously using time_slice=slice(None) when initializing the i…
bnb32 e2b452f
Adding cli entry points to pyproject.toml
bnb32 5383593
`_write_single` as classmethod in cacher
bnb32 93735f3
using _write_single instead of write_netcdf - absorbs handling of tmp…
bnb32 5046c7b
using _write_single instead of write_netcdf - absorbs handling of tmp…
bnb32 7082c87
ensuring correct ordering of input features to generator
bnb32 d2e7692
less verbose logging
bnb32 87254ef
using _write_single instead of write_netcdf - absorbs handling of tmp…
bnb32 8741fb9
`_write_single` feature parsing fix
bnb32 17d02ee
fix: already have file paths in input_handler_kwargs
bnb32 d7276a2
feat: sample obs frac for each batch element to build obs mask
bnb32 264fc47
removed embedded obs layer and fix tf.gather calls.
bnb32 b0bda95
test fix - obs mask to numpy from tensor.
bnb32 db1be8e
feat: enhance loss function handling in Sup3rGan and Sup3rGanWithObs …
bnb32 7de5183
bug fix with temporal_pad = 0
bnb32 b06b92c
updated docs for obs model use info. corrected some old doc strings. …
bnb32 4482ea4
test fix -> renamed get_obs_mask to _get_full_obs_mask to make privat…
bnb32 6ed7795
asserts instead of checks in ExoData init.
bnb32 4134834
bump required phygnn version
bnb32 20c4eb3
enabling loss_obs functions which require 2d or 3d tensors
bnb32 86ea30b
changed notebook to use all keys required for ExoData
bnb32 a5002b0
run_exo_layer methods for handling sup3r obs model layers
bnb32 f79983e
fix: check for means is None before norm in run exo layer
bnb32 c76fea1
refactor: use tf methods for obs loss calc and gpu splitting
bnb32 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.