Added Selective Parsing of Attributes by Tag Name #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified Options Builder to include new option - attributeTargetTags - Array Modified OrderedObjParser to check for attributeTargetTags and see if TagName is in the array
|
Can you please add a few tests for the same? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified Options Builder to include new option - attributeTargetTags - Array
Modified OrderedObjParser to check for attributeTargetTags and see if TagName is in the array
Purpose / Goal
Simple addition to only have attributes parsed from specific TagNames. This need arose from messy source xml where parsing all the attributes complicated and cluttered the resulting JSON. This will allow an array of tag names to be passed into options to filter what tags get their attributes expanded.
This addresses my idea #458. After posting about it, I realized it wouldn't take much to add it so I thought it would be a good chance to make my first commit to a module i like. I hope you like it!
Type
Please mention the type of PR
Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend
[WIP]in PR title. Your PR will be reviewed when[WIP]will be removed from the PR title.Bookmark this repository for further updates.