fix #593: support line numbers (5.x edition) #729
Draft
+77
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a new symbol, accessible via XMLParser.getStartIndexSymbol() which reflects the start index of a tag - copy that start index in the compressed form as well (cherry picked from commit d7601c3)
- correct .d.ts
|
Tests fail as they don't expect the symbols to be present. Tests passed on the 4.x version, perhaps a change in Jasmine now fails. |
srl295
added a commit
to keymanapp/keyman
that referenced
this pull request
Feb 28, 2025
- change to use a different fast-xml-parser PR, NaturalIntelligence/fast-xml-parser#729 Fixes: #10622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
For our XML based parser, we want to show the line number of where an errant XML element was found.
This PR adds a symbol to objects in the output tree with the start index (in chars) of the element.
Fixes #593
Type
Please mention the type of PR
Benchmark
(TBD)
Bookmark this repository for further updates.