-
-
Notifications
You must be signed in to change notification settings - Fork 624
Add E-Ink Mode theme support for e-ink displays #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VBansal99 As there were already complaints because AMOLED dark theme contains the word AMOLED maybe theme should be named more general and not use eInk at all IMO.
Instead we can use somthing like e.g. black on white, high contrast, or something else.
What do you think?
yes , we can do this. i have some name like Paper Mode , Ultra Contrast , Reading View like this |
|
@marunjar done the changes suggested by you |
- use correct value for case
|
Fixed one last thing for myself now. |
|
@marunjar so now it is ready to merge ? or any change required. |
As more black on white is wanted, maybe the same items should be set for new theme as already done for amoled-dark. |
|
@marunjar done some changes |
|
@marunjar done some changes, please review this. |
|
Looks fine to me, but I lack some eink device. |
Actually i could not understand that issue properly. |
Summary
The new mode provides a high-contrast, black-and-white visual style optimized for e-ink screens.
Related Issue
Fixes #2457 — High contrast mode for e-ink displays
Changes
applyTheme()method to recognize and apply the new themestyles.xmlScreenshots
(Add screenshots showing before and after, if possible)
Notes
Checklist