Fix MSVC C++20/23 module compatibility for static_str conversion operator #433
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderzhm
commented
Oct 15, 2025
banderzhm
commented
- Add explicit str() method to static_str for explicit string_view conversion
- Conditionally disable implicit operator string_view() in MSVC module mode
- Non-module builds and other compilers remain unaffected
…ator - Add explicit str() method to static_str for explicit string_view conversion - Conditionally disable implicit operator string_view() in MSVC module mode - This resolves C2833 error when using MAGIC_ENUM_USE_STD_MODULE with MSVC - Non-module builds and other compilers remain unaffected
Contributor
|
is static_str a public type? It shouldn't be and I think we should drop the conversion operator |
Author
|
Clang and MSVC behave completely differently.This is the best solution I could think of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.