Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
@MuratUrsavas @kashifpk @pritamghanghas @posterzh @KevinWassermann94 could you take a look at this PR and see if we can pull in? |
|
Cc @robputt |
robputt
left a comment
robputt
left a comment
There was a problem hiding this comment.
@TrellixVulnTeam Thanks for your PR.
Whilst I appreciate and understand the need for this CVE patch please may we ask a few questions prior to considering merge.
a) Why hasn't this been contributed to the Python built-in rather than raising a PR to thousands of open source projects?
b) If contribution to the built in is not possible, then why isn't this published as a PyPi package so that we may promote re-use, patching and distribution more simply?
c) Our PRs require that code coverage percentage is not adversely affected by a PR. Please can you provide unit tests for these new functions?
d) Having these functions inline breaches our style guide. Please can you refactor these into a "utilities.tar" module and implement here?
Best Regards,
Rob
3 participants
Patching CVE-2007-4559
Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.
If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.