use override values even if already set#683
Open
tchey290 wants to merge 4 commits intoNebraLtd:shawaj/hostnamefrom
Open
use override values even if already set#683tchey290 wants to merge 4 commits intoNebraLtd:shawaj/hostnamefrom
tchey290 wants to merge 4 commits intoNebraLtd:shawaj/hostnamefrom
Conversation
will always use the override password first, then check if one is already set, then generate a default one if neither of those are true.
will set the hostname to the override value even if it's already set
set override hostname even if already set
always use password override even if already set
|
Member
|
Thanks for this contribution @tchey290 👏 I was meaning to do this but been very short on time so this is much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
How
Screenshots
References
Checklist