chore: upgrade to node 18

Nebulis · Feb 18, 2024 · f0ee496 · f0ee496
1 parent 5270926
commit f0ee496
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -4,14 +4,14 @@ jobs:
   version:
     runs-on: ubuntu-latest
     container:
-      image: node:16
+      image: node:18
     steps:
     - run: node -v
     - run: npm -v
   bundle_dependencies:
     runs-on: ubuntu-latest
     container:
-      image: node:16
+      image: node:18
     steps:
 #    - name: Install OS dependencies
 #      run: |-
@@ -26,7 +26,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     container:
-      image: node:16
+      image: node:18
     needs:
     - bundle_dependencies
     steps:
@@ -43,7 +43,7 @@ jobs:
   build_with_ssr:
     runs-on: ubuntu-latest
     container:
-      image: node:16
+      image: node:18
     needs:
     - bundle_dependencies
     steps:
@@ -57,7 +57,7 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     container:
-      image: node:16
+      image: node:18
     needs:
     - bundle_dependencies
     steps:
@@ -71,7 +71,7 @@ jobs:
   types:
     runs-on: ubuntu-latest
     container:
-      image: node:16
+      image: node:18
     needs:
     - bundle_dependencies
     steps:
@@ -85,7 +85,7 @@ jobs:
   test:
     runs-on: ubuntu-latest
     container:
-      image: node:16
+      image: node:18
     needs:
     - bundle_dependencies
     steps:

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v16.16.0
+v18.17.0
diff --git a/src/use-dimensions.tsx b/src/use-dimensions.tsx
@@ -22,7 +22,11 @@ export interface NoDimensionObject {
   bottom?: never
 }
 
-export type UseDimensionsHook = [(node: HTMLElement | null) => void, NoDimensionObject | DimensionObject, HTMLElement | null]
+export type UseDimensionsHook = [
+  (node: HTMLElement | null) => void,
+  NoDimensionObject | DimensionObject,
+  HTMLElement | null
+]
 
 export interface UseDimensionsArgs {
   liveMeasure?: boolean
@@ -66,7 +70,7 @@ function useDimensions({ liveMeasure = true }: UseDimensionsArgs = {}): UseDimen
         }
       }
     }
-  }, [node])
+  }, [node, liveMeasure])
 
   return [ref, dimensions, node]
 }