-
Notifications
You must be signed in to change notification settings - Fork 0
Add hw2_signer solution #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| wg.Wait() | ||
| } | ||
|
|
||
| func CombineResults(in, out chan interface{}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported function CombineResults should have comment or be unexported
| wg.Wait() | ||
| } | ||
|
|
||
| func MultiHash(in, out chan interface{}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported function MultiHash should have comment or be unexported
| close(out) | ||
| } | ||
|
|
||
| func SingleHash(in, out chan interface{}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported function SingleHash should have comment or be unexported
| "sync" | ||
| ) | ||
|
|
||
| func ExecutePipeline(jobs ...job) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported function ExecutePipeline should have comment or be unexported
| // я преопределяю фукции на свои которые инкрементят локальный счетчик | ||
| // переопределение возможо потому что я объявил функцию как переменную, в которой лежит функция | ||
| var ( | ||
| DataSignerSalt string = "" // на сервере будет другое значение |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should drop = "" from declaration of var DataSignerSalt; it is the zero value
| } | ||
| } | ||
|
|
||
| var OverheatUnlock = func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported var OverheatUnlock should have comment or be unexported
| DataSignerSalt = "" | ||
| ) | ||
|
|
||
| var OverheatLock = func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported var OverheatLock should have comment or be unexported
|
|
||
| var ( | ||
| dataSignerOverheat uint32 = 0 | ||
| DataSignerSalt = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported var DataSignerSalt should have comment or be unexported
| ) | ||
|
|
||
| var ( | ||
| dataSignerOverheat uint32 = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should drop = 0 from declaration of var dataSignerOverheat; it is the zero value
| type job func(in, out chan interface{}) | ||
|
|
||
| const ( | ||
| MaxInputDataLen = 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported const MaxInputDataLen should have comment (or a comment on this block) or be unexported
No description provided.