Skip to content

Conversation

@Neodelf
Copy link
Owner

@Neodelf Neodelf commented Feb 10, 2019

No description provided.

wg.Wait()
}

func CombineResults(in, out chan interface{}) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported function CombineResults should have comment or be unexported

wg.Wait()
}

func MultiHash(in, out chan interface{}) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported function MultiHash should have comment or be unexported

close(out)
}

func SingleHash(in, out chan interface{}) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported function SingleHash should have comment or be unexported

"sync"
)

func ExecutePipeline(jobs ...job) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported function ExecutePipeline should have comment or be unexported

// я преопределяю фукции на свои которые инкрементят локальный счетчик
// переопределение возможо потому что я объявил функцию как переменную, в которой лежит функция
var (
DataSignerSalt string = "" // на сервере будет другое значение
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should drop = "" from declaration of var DataSignerSalt; it is the zero value

}
}

var OverheatUnlock = func() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported var OverheatUnlock should have comment or be unexported

DataSignerSalt = ""
)

var OverheatLock = func() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported var OverheatLock should have comment or be unexported


var (
dataSignerOverheat uint32 = 0
DataSignerSalt = ""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported var DataSignerSalt should have comment or be unexported

)

var (
dataSignerOverheat uint32 = 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should drop = 0 from declaration of var dataSignerOverheat; it is the zero value

type job func(in, out chan interface{})

const (
MaxInputDataLen = 100
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported const MaxInputDataLen should have comment (or a comment on this block) or be unexported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants