feat: adding serial in hex format in LUN table #4034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR adds serial number information in hexadecimal format to the LUN table in the Grafana dashboard by switching from the public REST API to the private CLI API endpoint. The change enables display of the serial_hex field alongside existing LUN metrics.
Key changes:
- Switched LUN data collection from
api/storage/lunstoapi/private/cli/lunto access serial_hex field - Added
serial_hexcolumn to the Grafana LUN dashboard table - Updated documentation to reflect the new API endpoint and field mappings
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| conf/rest/9.12.0/lun.yaml | Changed query endpoint from public REST API to private CLI API and updated field mappings to include serial_hex |
| grafana/dashboards/cmode/lun.json | Added serial_hex column to LUN table with display name "Serial Hex" and capitalized "Status" label |
| docs/ontap-metrics.md | Updated documentation to reflect new API endpoint, removed netstat metrics, and added poller_concurrent_collectors metric |
| mcp/metadata/ontap_metrics.json | Removed netstat metrics and added poller_concurrent_collectors metric |
| cmd/tools/generate/counter.yaml | Added descriptions for lun_size and lun_size_used metrics |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgrinds
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @Venumadhu for reporting!