Skip to content

ci: unit test should fail ZapiPerf templates when detect caret #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgrinds merged 3 commits into from
Nov 26, 2025
Merged

ci: unit test should fail ZapiPerf templates when detect caret #4043

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9908def
ci: unit test should fail ZapiPerf templates when detect caret
Hardikl Nov 26, 2025
c0a6da8
ci: unit test should fail ZapiPerf templates when detect caret
Hardikl Nov 26, 2025
74f2028
ci: handled review comment
Hardikl Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cmd/tools/template/template_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,17 @@ func TestMetricsAreSortedAndNoDuplicates(t *testing.T) {
}, allTemplatesButEms...)
}

// Tests that zapiperf metrics should not have caret
func TestZapiPerfMetricsHaveNoCaret(t *testing.T) {
visitTemplates(t, func(path string, model Model) {
for _, metric := range model.metrics {
if strings.HasPrefix(metric.line, "^") {
t.Errorf("counter %s should not have ^^ at path=[%s]", metric.line, shortPath(path))
}
}
}, []string{"zapiperf"}...)
}

func checkForDuplicateMetrics(t *testing.T, model Model, path string) {
dupSet := make(map[string]bool)
for _, m := range model.metrics {
Expand Down
Loading