Refactor party size to use long instead of int #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `JsonParty.Size` to `long[]?` to support larger values. Replaced `CurrentSize` and `MaxSize` in `Party` with `PartySize`. Introduced `PartySize` class for better encapsulation. Updated `PartySizeProperties` to use `long` for size properties.
|
The documentation preview is available at https://preview.netcord.dev/208. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the party size handling in the Gateway module to use long instead of int for size values and introduces a new PartySize wrapper class to encapsulate the size array.
- Changed party size data types from
inttolongacross all related classes - Introduced
PartySizeclass to wrap the size array and exposeCurrentSizeandMaxSizeproperties - Refactored
Partyclass to use the newPartySizetype instead of separate nullable properties
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| NetCord/Gateway/PartySize.cs | New wrapper class for party size data that implements IJsonModel<long[]> |
| NetCord/Gateway/Party.cs | Refactored to use PartySize object instead of separate properties |
| NetCord/Gateway/PartySizeProperties.cs | Changed property and parameter types from int to long |
| NetCord/Gateway/JsonModels/JsonParty.cs | Changed Size array type from int[] to long[] |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
JsonParty.Sizetolong[]?to support larger values. ReplacedCurrentSizeandMaxSizeinPartywithPartySize. IntroducedPartySizeclass for better encapsulation. UpdatedPartySizePropertiesto uselongfor size properties.