Skip to content

Refactor event invocation #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KubaZ2 merged 9 commits into from
Nov 7, 2025
Merged

Refactor event invocation #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0cb684b
Refactor event invocation in websocket clients
KubaZ2 Nov 6, 2025
cfc61e0
Cleanup
KubaZ2 Nov 6, 2025
fb9c11c
Add a missing `static` modifier
KubaZ2 Nov 6, 2025
f37b0c6
Refactor `InvokeEventAsync`
KubaZ2 Nov 6, 2025
214d851
Remove an unused `InvokeEventAsync` overload
KubaZ2 Nov 6, 2025
945bea0
Add a missing `static` modifier
KubaZ2 Nov 7, 2025
70648d5
Refactor WebSocketClient InvokeEventAsync methods
KubaZ2 Nov 7, 2025
c740605
Refactor generic constraints in WebSocketClient methods
KubaZ2 Nov 7, 2025
5275016
Refactor event handling for consistency and clarity
KubaZ2 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions NetCord/Gateway/EventArgs/ReadyEventArgs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ public class ReadyEventArgs : IJsonModel<JsonModels.EventArgs.JsonReadyEventArgs

public Shard? Shard => _jsonModel.Shard;

public ulong ApplicationId => _jsonModel.Application is null ? default : _jsonModel.Application.Id;
public ulong ApplicationId => _jsonModel.Application.Id;

public ApplicationFlags ApplicationFlags => _jsonModel.Application is null ? default : _jsonModel.Application.Flags.GetValueOrDefault();
public ApplicationFlags ApplicationFlags => _jsonModel.Application.Flags.GetValueOrDefault();

public ReadyEventArgs(JsonModels.EventArgs.JsonReadyEventArgs jsonModel, RestClient client)
{
Expand Down
Loading
Loading