Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#220 update the cookie layer options in main tag #269

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jonatan-lledo-netcentric
Copy link
Collaborator

Tested using a snippet of the Chrome devTools, but not tested in localhost

Fix #220

Test URLs:

@jonatan-lledo-netcentric jonatan-lledo-netcentric linked an issue Jan 27, 2023 that may be closed by this pull request
@aem-code-sync
Copy link

aem-code-sync bot commented Jan 27, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jan 27, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@nc-andreashaller
Copy link
Collaborator

Are we sure we want to have this code here instead of Adobe Launch?

@verlok-cn
Copy link

verlok-cn commented Jan 27, 2023

The code looks good to me, even if I couldn't try it in the generated environments.

I'm fine to have the code in Adobe Launch, if it works.
What do you think @jonatan-lledo-netcentric, will it work if moved to Adobe Launch?

@aem-code-sync
Copy link

aem-code-sync bot commented Jan 30, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@jonatan-lledo-netcentric
Copy link
Collaborator Author

I'm fine to have the code in Adobe Launch, if it works. What do you think @jonatan-lledo-netcentric, will it work if moved to Adobe Launch?

As I said in the description, the code is tested using the snippets tab in the Chrome devTools. It should work if it is moved to Adobe Launch IMHO.

@aem-code-sync
Copy link

aem-code-sync bot commented Jan 31, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jan 31, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@NCalexiaeche NCalexiaeche requested review from alexnerdrumhansen and removed request for alexnerdrumhansen May 9, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate cookie layer with data-domain
4 participants