-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
285 new css styling option on cards #293
base: main
Are you sure you want to change the base?
285 new css styling option on cards #293
Conversation
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
The following functionalities have been tested on this ticket:
Please find attached some of the pages where the affected component is used and you can see the behaviour, on the left side the page in production and on the right side how it looks with the new changes in the branch.
When the behaviour of the brightness filter component is decided, all functionalities will be reviewed again. |
As we have discussed on the slack channel, by applying the same component on photos and colours it will work on colours but on photos it will look too bright and the text will not be legible, we should apply one solution for colours (which is the new brightness that is being developed) and create a new flavour for images, so they look correctly |
This ticket excludes the images, this block should be used only for background plain color, it should not be possible to be used with any images |
Colours don't seem to be matching the accessibility approved colours, https://projects.netcentric.biz/wiki/display/NCWEB/Accessibility+colour+recommendation |
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
@tomasznetcentric please, if you think this PR is ready, merge it for me. thanks |
I checked the pr code wise. But yes maybe I miss some context here. Will setup a alignment for us. |
for the 1st and 2nd style issues, it can be check in index, and for the 3rd, Y add a draft for the purposes in
/drafts/jlledo/index-demo
/drafts/jlledo/rainbow-demo
Fix #285
Test URLs: