Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

285- Change text color for of banners for better acesseblity #315

Merged
merged 1 commit into from
May 9, 2023

Conversation

sonaldhekale
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@sonaldhekale sonaldhekale linked an issue Mar 30, 2023 that may be closed by this pull request
3 tasks
@aem-code-sync
Copy link

aem-code-sync bot commented Mar 30, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 30, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@alexnerdrumhansen
Copy link
Collaborator

As far as I can see the text colour in the banner is looking alright now (https://285-accessblity-banner-text--cn-website--netcentric.hlx.page/how-we-work/communities)

@nc-andreashaller nc-andreashaller merged commit 08e55a3 into main May 9, 2023
@nc-andreashaller nc-andreashaller deleted the 285-accessblity-banner-text branch May 9, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New CSS styling option on Images & Banner Style color change
4 participants