Skip to content

[WIP] fix: resolution notes markdown #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mvilanova
Copy link
Contributor

No description provided.

@mvilanova mvilanova self-assigned this Jun 5, 2025
@mvilanova mvilanova added the bug Something isn't working label Jun 5, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes ValidationError usage across several get_by_name_or_raise functions, cleans up formatting (imports, trailing commas, blank lines), fixes a typo in the Dockerfile comment, and updates pre-commit hook configurations.

  • Normalize how ValidationError is raised in source/query services
  • Refactor multi-line imports and trailing commas for consistency
  • Bump pre-commit hook versions and refine their settings

Reviewed Changes

Copilot reviewed 103 out of 103 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/dispatch/data/source/transport/service.py Reformatted raise ValidationError call
src/dispatch/data/source/status/service.py Reformatted raise ValidationError call
src/dispatch/data/source/service.py Reformatted raise ValidationError call
src/dispatch/data/source/environment/service.py Reformatted raise ValidationError call
src/dispatch/data/source/data_format/service.py Reformatted raise ValidationError call
src/dispatch/data/query/service.py Reformatted raise ValidationError call
src/dispatch/data/alert/service.py Removed stray hyphen
src/dispatch/conversation/models.py Added blank lines for readability
src/dispatch/conference/service.py Removed stray hyphen
src/dispatch/case_cost_type/service.py Flattened function signatures
src/dispatch/case/views.py Expanded imports into multi-line form and added blank line
src/dispatch/case/type/models.py Added blank lines around Pydantic models
src/dispatch/case/service.py Merged multi-line f-strings into one
src/dispatch/case/models.py Added blank lines around pagination classes
src/dispatch/case/messaging.py Added trailing comma to dict literal
src/dispatch/case/flows.py Added trailing comma in import list
src/dispatch/auth/service.py Reformatted model_dump call with trailing comma
docker/Dockerfile Corrected typo from “directoy” to “directory”
.pre-commit-config.yaml Upgraded hook versions and refined hook configurations
.coveragerc Removed stray dash at end of file
Comments suppressed due to low confidence (2)

src/dispatch/data/source/environment/service.py:46

  • [nitpick] The loc key is set to 'source' but this error refers to the source_environment; consider using ('source_environment',) for clearer error location.
"loc": ("source",),

src/dispatch/data/source/data_format/service.py:44

  • [nitpick] The loc key uses camelCase 'dataFormat'; consider aligning with snake_case field names (e.g. 'data_format') to match project conventions.
"loc": ("dataFormat",),

@mvilanova mvilanova changed the title fix: resolution notes markdown [WIP] fix: resolution notes markdown Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant