-
Notifications
You must be signed in to change notification settings - Fork 589
Manage participants from UI #6087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…n_manage_participants
…e_participants_from_ui
…lix/dispatch into manage_participants_from_ui
@whitdog47 @aaronherman all checks are passing now! can I get a review whenever y'all get a chance? thank you! |
log.warning("No conversation enabled for this case.") | ||
return | ||
|
||
slack_conversation_plugin.instance.remove_user( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One downside to this approach is that if the user was removed directly in the Slack channel, it will also kick off this flow, which will throw an error in remove_user() since they no longer exist in the channel.
log.warning("No conversation enabled for this incident.") | ||
return | ||
|
||
slack_conversation_plugin.instance.remove_user( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same feedback as above.
This PR adds the ability to manage (e.g. add or remove) participants from the UI.
Frontend Changes
RemoveParticipantDialog.vue
for both incidents and casesremoveParticipant
andaddParticipant
methods to both incident and case APIsBackend Changes
/{case_id}/remove/{email}
,/{case_id}/add/{email}
,/{incident_id}/remove/{email}
, and/{incident_id}/add/{email}
Screenshots

Timeline event for being added to a conversation
Timeline event for being removed from a conversation

New UI to add participants from the dropdown menu and remove participants with the delete icon

Confirmation dialog before removing a participant
