JobActor::WorkerManager's logs contain the WorkerID that they correspond to

[GautamGottipati]

Context

Explain context and other details for this pull request.

Checklist

• ./gradlew build compiles code correctly
• Added new tests where applicable
• ./gradlew test passes all tests
• Extended README or added javadocs where applicable

[Andyz26]

Introducing extra lifecycle for these loggers doesn't seem to provide enough benefits. Adding the extra metadata to the logger message is sufficient enough.

[GautamGottipati]

Hi @Andyz26 can you please give me some hints, like what metadata I could add and how. In the issue it was mentioned to implement something like this workerManager.info("Whatever"); where by default workerId should be added. Taking reference from issue #384

[Andyz26]

The issue is about jobId at the job actor level and that is a different structure comparing to this workerManager. Here WorkerManager is not 1 to 1 mapping with a specific worker logically. There is no need to maintain a worker-level logger as long as the information needed is logged.

[GautamGottipati]

so you mean, I can directly add worker Id to Logger.info, where ever worker id is not mentioned.

[Andyz26]

In this case yes.

…

On Wed, Apr 12, 2023 at 10:52 AM Gottipati Gautam ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/master/jobcluster/job/JobActor.java <#411 (comment)>: > @@ -1286,6 +1288,8 @@ class WorkerManager implements IWorkerManager { .build(); private volatile boolean stageAssignmentPotentiallyChanged; + private WorkerManagerLogger workerLogger; so you mean, I can directly add worker Id to Logger.info, where ever worker id is not mentioned. — Reply to this email directly, view it on GitHub <#411 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AU5L2E3SSC7QB54ESUL2ZW3XA3TUHANCNFSM6AAAAAAWVFZ534> . You are receiving this because you were mentioned.Message ID: ***@***.***>