Replace slotId tag with clientId in PushServer#764
Merged
Conversation
In pushServer the slotId tag cardinality is too big and we can achieve similar granularity using combination of clientId + infra tags
Andyz26
requested review from
calvin681,
dtrager02,
fdc-ntflx and
hmitnflx
as code owners
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
markcho
approved these changes
Apr 11, 2025
hmitnflx
approved these changes
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In pushServer the slotId tag's cardinality is too big and costly and we can achieve similar granularity using a combination of clientId + infra tags.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests