Add complete Colima support for metaflow-dev #2530
Open
+243
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Docker context management to properly route commands through Colima - Configure required environment variables (DOCKER_HOST, etc.) - Add setup script for easy Colima configuration - Support both Docker Desktop and Colima transparently - Add comprehensive documentation for Colima usage - Maintain backward compatibility with Docker Desktop This enables users who cannot use Docker Desktop due to licensing to use Colima as a drop-in replacement for Metaflow development. Fixes Netflix#2362
…OS compatibility - Export DOCKER_HOST and related variables for sub-processes - Make vm-type conditional based on macOS version (vz requires macOS 13+) - Ensures Colima configuration is properly used throughout the build process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds complete support for Colima as an alternative to Docker Desktop for running
metaflow-devon macOS.Problem
The current
check-dockertarget in devtools/Makefile usesopen -a Dockerwhich only works with Docker Desktop. This prevents users who use Colima (or other Docker alternatives) from usingmetaflow-dev.Solution
Implemented full Colima integration including:
Changes
devtools/Makefileto support multiple Docker runtimesdevtools/setup-colima.shfor automated Colima setupdocs/colima.mdwith usage documentationTesting
Tested on macOS with:
Related Issues
This is a complete implementation following feedback from #2520
Fixes #2362