Skip to content

fix for error capture script #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

fix for error capture script #2633

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71e5100
fix for error capture script
iamsgarg-ob Oct 8, 2025
0ff3d63
lint
iamsgarg-ob Oct 8, 2025
d997de2
include sakari's comment
iamsgarg-ob Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions metaflow/plugins/argo/capture_error.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import json
import os
from datetime import datetime
from datetime import datetime, timezone

###
# Algorithm to determine 1st error:
Expand All @@ -26,6 +26,9 @@ def parse_workflow_failures():
def group_failures_by_template(failures):
groups = {}
for failure in failures:
if "finishedAt" in failure and failure["finishedAt"] is None:
timestamp = datetime.now(timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
failure["finishedAt"] = timestamp
groups.setdefault(failure["templateName"], []).append(failure)
return groups

Expand Down Expand Up @@ -53,7 +56,7 @@ def determine_first_error():
grouped_failures = group_failures_by_template(failures)
for group in grouped_failures.values():
group.sort(
key=lambda x: datetime.strptime(x["finishedAt"], "%Y-%m-%dT%H:%M:%SZ")
key=lambda g: datetime.strptime(g["finishedAt"], "%Y-%m-%dT%H:%M:%SZ")
)

earliest_group = grouped_failures[
Expand Down
Loading