Adding lemmas about EVM state and addresses #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2024
Julek
requested changes
Oct 7, 2024
| lemma top_lt_UInt256_size : top < UInt256.size := by decide | ||
| lemma top_le_UInt256_size : top ≤ UInt256.size := le_of_lt top_lt_UInt256_size | ||
|
|
||
| lemma ofUInt256_lt_UInt256_size {u : UInt256} : ↑(ofUInt256 u) < UInt256.size := by |
Collaborator
There was a problem hiding this comment.
Shorted version that doesn't use open simps:
lemma ofUInt256_lt_UInt256_size {u : UInt256} : ↑(ofUInt256 u) < UInt256.size := by
unfold ofUInt256 Fin.ofNat
trans (2 ^ 160) <;>
simp only [UInt256.size, Nat.reducePow, Nat.reduceAdd, gt_iff_lt, Nat.ofNat_pos, Nat.mod_lt, Nat.reduceLT]
Collaborator
There was a problem hiding this comment.
In general, we have a strong preference for only using open simps as a closing tactic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkopanski asked me to make a series of pull requests (#6 #7 #8 #9) bringing in work from the
erc20branch that is applicable more generally. This one adds lemmas about the EVM state and addresses.All except #9 should be able to be merged in any order.
I have tested that
lake buildsucceeds.