Skip to content

Benchmarks for operations on *_monty_field types and improved division #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ElijahVlasov merged 4 commits into from
Nov 28, 2025
Merged

Benchmarks for operations on *_monty_field types and improved division #11

ElijahVlasov merged 4 commits into from
Nov 28, 2025

Conversation

@ElijahVlasov
Copy link
Collaborator

@ElijahVlasov ElijahVlasov commented Nov 21, 2025

  1. Moved benchmarks for the arithmetic operations here and duplicated them for each type of a field.
  2. Shortened the implementations of Inv and CheckedDiv for all bigint fields and improved performance of the operation.

@ElijahVlasov
Copy link
Collaborator Author

ElijahVlasov commented Nov 21, 2025 •
edited
Loading

  1. Shortened the implementations of Inv and CheckedDiv for all bigint fields and improved performance of the operation.

The improvement is consistent 60-70% on my machine

frozenspider
frozenspider reviewed Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@frozenspider frozenspider left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 3 benches seems to be doing an exact same thing. Can we move the common code out and abstract it over PrimeField much like we did for Zip+?

frozenspider
frozenspider approved these changes Nov 28, 2025
View reviewed changes
@ElijahVlasov ElijahVlasov merged commit f995791 into main Nov 28, 2025
10 checks passed
@ElijahVlasov ElijahVlasov deleted the ElijahVlasov/op_benches branch November 28, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frozenspider frozenspider frozenspider approved these changes

@maksimryndin maksimryndin Awaiting requested review from maksimryndin maksimryndin is a code owner

@cupicmarko cupicmarko Awaiting requested review from cupicmarko cupicmarko is a code owner

@NiDimi NiDimi Awaiting requested review from NiDimi NiDimi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ElijahVlasov @frozenspider