Add FromPrimitiveWithConfig trait.
#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElijahVlasov
requested review from
NiDimi,
cupicmarko,
frozenspider and
maksimryndin
as code owners
The trait combines all `FromWithConfig<u*>` and `FromWithConfig<i*>` into one umbrella trait. Handy when one needs conversion functions for different primitive int types.
ElijahVlasov
force-pushed
the
ElijahVlasov/from-primitive-with-config
branch
from
768abfa to
9266c66
Compare
NiDimi
approved these changes
Nov 12, 2025
NiDimi
left a comment
NiDimi
left a comment
There was a problem hiding this comment.
Looks good! I think it makes sense to avoid repeating multiple FromWithConfig bounds. Found a small typo outside the scope.
ElijahVlasov
force-pushed
the
ElijahVlasov/from-primitive-with-config
branch
from
87d62f0 to
3078802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trait combines all
FromWithConfig<u*>andFromWithConfig<i*>into one umbrella trait. Handy when one needs conversion functions for different primitive int types.The canonical blanket implementation is provided as well.