Skip to content

pre-push hook checks for sorted deps #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maksimryndin merged 2 commits into from
May 27, 2025
Merged

pre-push hook checks for sorted deps #1

maksimryndin merged 2 commits into from
May 27, 2025

Conversation

@maksimryndin
Copy link
Collaborator

@maksimryndin maksimryndin commented May 23, 2025 •
edited
Loading

  • pre-push hook with alphabetical deps sorting check

Oghma
Oghma reviewed May 23, 2025
View reviewed changes
@v0-e
Copy link
Member

v0-e commented May 23, 2025

I agree with @Oghma, it is best we avoid mechanisms that modify the code in a "hidden" way (git commit shouldn't do it). Best to just check 👍

@maksimryndin
Copy link
Collaborator Author

maksimryndin commented May 23, 2025

I've added just a sorting check to the pre-push and made if-then checks.
thank you for the review @Oghma @v0-e!

cupicmarko
cupicmarko reviewed May 23, 2025
View reviewed changes
@maksimryndin maksimryndin changed the title pre-commit hook pre-push hook checks for sorted deps May 23, 2025
Oghma
Oghma approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@Oghma Oghma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maksimryndin maksimryndin merged commit f97b494 into main May 27, 2025
4 checks passed
@maksimryndin maksimryndin deleted the feat/pre-commit branch May 27, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cupicmarko cupicmarko cupicmarko left review comments

@Oghma Oghma Oghma approved these changes

@v0-e v0-e Awaiting requested review from v0-e

@frozenspider frozenspider Awaiting requested review from frozenspider

@NiDimi NiDimi Awaiting requested review from NiDimi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maksimryndin @v0-e @Oghma @cupicmarko