-
Notifications
You must be signed in to change notification settings - Fork 2
Build benchmarks in GitHub actions #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Co-authored-by: v0-e <[email protected]>
maksimryndin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElijahVlasov thanks for the contribution :)
What is the rationale of building benches without running them?
Well, it's definitely worth looking into things like https://github.com/marketplace/actions/continuous-benchmark. For the time being, it's nice to see when benches fail to build, not to figure out why the clippy step's failed. |
v0-e
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Co-authored-by: v0-e <[email protected]>
84f310c to
6a43472
Compare
Does @cupicmarko you've cooked some benchmark action? Can we use it? |
|
Does it make sense to remove - name: Build
run: cargo test --workspace --verbose --no-run? |
Yeah 👍 |
@maksimryndin yes, I can publish it as a github-action and we can try it on a real project. |
|
On the |
It's nice to have a dedicated step that builds benchmarks.