Skip to content

Conversation

@ElijahVlasov
Copy link
Contributor

It's nice to have a dedicated step that builds benchmarks.

@ElijahVlasov ElijahVlasov requested a review from a team as a code owner December 2, 2025 12:26
@v0-e
Copy link
Member

v0-e commented Dec 2, 2025

--all-targets is cool too 😄

Co-authored-by: v0-e <[email protected]>
Copy link
Collaborator

@maksimryndin maksimryndin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElijahVlasov thanks for the contribution :)

What is the rationale of building benches without running them?

@ElijahVlasov
Copy link
Contributor Author

@ElijahVlasov thanks for the contribution :)

What is the rationale of building benches without running them?

Well, it's definitely worth looking into things like https://github.com/marketplace/actions/continuous-benchmark.

For the time being, it's nice to see when benches fail to build, not to figure out why the clippy step's failed.

Copy link
Member

@v0-e v0-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maksimryndin
Copy link
Collaborator

@ElijahVlasov thanks for the contribution :)
What is the rationale of building benches without running them?

Well, it's definitely worth looking into things like https://github.com/marketplace/actions/continuous-benchmark.

For the time being, it's nice to see when benches fail to build, not to figure out why the clippy step's failed.

Does cargo check --benches do the job? (it is more lightweight

@cupicmarko you've cooked some benchmark action? Can we use it?

@ElijahVlasov
Copy link
Contributor Author

Does it make sense to remove

- name: Build
      run: cargo test --workspace --verbose --no-run

?

@v0-e
Copy link
Member

v0-e commented Dec 2, 2025

Does it make sense to remove

Yeah 👍

@cupicmarko
Copy link
Contributor

@cupicmarko you've cooked some benchmark action? Can we use it?

@maksimryndin yes, I can publish it as a github-action and we can try it on a real project.

@maksimryndin
Copy link
Collaborator

On the cargo build everything it may slowdown things without actual use in this job except tests.
We can use cargo check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants