Skip to content

Cache llvm-cov tool #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frozenspider merged 1 commit into from
Dec 26, 2025
Merged

Cache llvm-cov tool #34

frozenspider merged 1 commit into from
Dec 26, 2025

Conversation

@frozenspider
Copy link
Contributor

@frozenspider frozenspider commented Dec 25, 2025 •
edited
Loading

Installing cargo-llvm-cov each time takes a long time and is wasteful. Cache it the same way we cache cargo-deny.

GH Action Time before Time after
Coverage (PR) 166 seconds 38 seconds
Coverage (Push) 87 seconds 18 seconds

@frozenspider frozenspider requested a review from a team as a code owner December 25, 2025 15:50
@Fantoni0
Copy link
Contributor

Fantoni0 commented Dec 26, 2025

I think it works, and times are much better.
But recently, I had some issues with the cache of cargo deny https://github.com/NethermindEth/stellar-private-transactions/pull/57
We were using an outdated version that was not compatible with newer advisory databases. Even if I updated the version, which cargo deny succeeded, and the new version was not installed.
Could something like this also happen for cache-llvm-cov?

@frozenspider
Copy link
Contributor Author

frozenspider commented Dec 26, 2025 •
edited
Loading

@Fantoni0, I've ran into that too. However, the short-term fix is pretty simple - go to Actions > Caches and delete a relevant cache.
I think caching is still worth it even though this might become a problem occasionally.

Fantoni0
Fantoni0 approved these changes Dec 26, 2025
View reviewed changes
Copy link
Contributor

@Fantoni0 Fantoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maksimryndin
maksimryndin approved these changes Dec 26, 2025
View reviewed changes
Copy link
Collaborator

@maksimryndin maksimryndin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@frozenspider frozenspider merged commit 9513a3a into main Dec 26, 2025
9 checks passed
@frozenspider frozenspider deleted the f/cache-llvm-cov branch December 26, 2025 12:55
This was referenced Dec 26, 2025
Open
Merged
frozenspider added a commit that referenced this pull request Dec 26, 2025
@frozenspider
Make caching GitHub actions use separate caches (#35)
ff95ea1 
A follow-up to #34 
Once cache is formed, it's not updated anymore (see
actions/toolkit#505). As such, it doesn't make
sense having the cache shared between unrelated actions.
Made each action using a cache key tied to its tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fantoni0 Fantoni0 Fantoni0 approved these changes

@maksimryndin maksimryndin maksimryndin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frozenspider @Fantoni0 @maksimryndin