Skip to content

Conversation

@JuliaSprenger
Copy link
Member

@JuliaSprenger JuliaSprenger commented Oct 25, 2022

This PR adds an additional utility function for finding a suitable IO for a given dataset. In addition to the get_io functions, there's now also an list_candidate_ios function, that provides a list of all IOs supporting the formats detected in a given path. This list is generated based on the file extension of the file or the extensions of the matching files in a given folder, potentially also scanning subfolders if required.

I added a common test to verify the correct IO for each test dataset is found, extended the list of linked extensions for IOs where required and removed some outdated test utility functions.

@JuliaSprenger JuliaSprenger added this to the 0.12.0 milestone Oct 25, 2022
@JuliaSprenger JuliaSprenger marked this pull request as ready for review November 3, 2022 13:43
@JuliaSprenger
Copy link
Member Author

@samuelgarcia What do you think of this approach? With some file formats being supported by multiple IOs (e.g. .txt for the AsciiSignal and AsciiSpikeTrainIO) we can not always determine 100% the suitable IO, but with this approach users can still retrieve a very reduced set of IOs to test.

@apdavison apdavison merged commit c3b8d10 into NeuralEnsemble:master Jan 12, 2023
@JuliaSprenger JuliaSprenger deleted the enh/get_io branch July 27, 2023 09:04
@zm711 zm711 mentioned this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants