-
Notifications
You must be signed in to change notification settings - Fork 264
[IO] Extend utilities to find suitable IO for a dataset #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rning a single one.
…stClass and not once per test
…with nested-folder folders
|
@samuelgarcia What do you think of this approach? With some file formats being supported by multiple IOs (e.g. |
JuliaSprenger
commented
Dec 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional utility function for finding a suitable IO for a given dataset. In addition to the
get_iofunctions, there's now also anlist_candidate_iosfunction, that provides a list of all IOs supporting the formats detected in a given path. This list is generated based on the file extension of the file or the extensions of the matching files in a given folder, potentially also scanning subfolders if required.I added a common test to verify the correct IO for each test dataset is found, extended the list of linked extensions for IOs where required and removed some outdated test utility functions.