Within Session splitter #664
Conversation
Deleting unified_eval, so it can be addressed on another pr. Working on tests.
Adding: figures for documentation
Signed-off-by: Bruna Junqueira Lopes <[email protected]>
# Conflicts: # moabb/evaluations/metasplitters.py # moabb/tests/metasplits.py
Add shuffle and random_state parameters to WithinSession
|
Hi, @tomMoral, @bruAristimunha , @PierreGtch ! I added the functionality to pass a metasplitter, such as TimeSeries/PseudoOnline. The way I designed this object, metasplitter returns indexes for calibration and test sets. To ensure the splitter returns indexes for a train set also, if needed, I was wondering if we could always have StratifiedKFold to split train/test, and allow to pass PseudoOnline as an inner_cv to further split the test set into calibration and test if wanted. |
There was a problem hiding this comment.
Hi @brunaafl, thanks for all the work you put in!! About the delay, this is all voluntary work, so no need to apologise :)
I added the functionality to pass a metasplitter, such as TimeSeries/PseudoOnline. The way I designed this object, metasplitter returns indexes for calibration and test sets. To ensure the splitter returns indexes for a train set also, if needed, I was wondering if we could always have StratifiedKFold to split train/test, and allow to pass PseudoOnline as an inner_cv to further split the test set into calibration and test if wanted.
I’m not sure I understand your question. What is the difference between the train and the calibration sets?
I also left a few comments on the code
# Conflicts: # moabb/evaluations/metasplitters.py # moabb/evaluations/splitters.py
# Conflicts: # moabb/evaluations/splitters.py
Head branch was pushed to by a user without write access
|
please approve @tomMoral and @PierreGtch asap |
This PR is a follow-up on PR #624 and is related to issue #612. It includes just the implementation for the WithinSessionSplitter data splitter.