Correct permutation t-tests #684
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gcattan <[email protected]>
|
Ok thanks ! Just to give more context: we wanted to display the summary plot with many datasets.
When computing the dataset statistics, we spot this warning saying there were some NaN values out of the stouffer method.
When looking at the p-values some were greater or equals to 1.
Envoyé à partir de Outlook pour Android<https://aka.ms/AAb9ysg>
…________________________________
From: Bru ***@***.***>
Sent: Friday, February 7, 2025 6:47:18 PM
To: NeuroTechX/moabb ***@***.***>
Cc: gcattan ***@***.***>; Mention ***@***.***>
Subject: Re: [NeuroTechX/moabb] Correct permutation t-tests (PR #684)
hey @gcattan<https://github.com/gcattan>,
I am not a super expert on t-tests, I am pinging @sylvchev<https://github.com/sylvchev> here.
—
Reply to this email directly, view it on GitHub<#684 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABPQYJ2C6QG7QBJ7KBH45GL2OTWSNAVCNFSM6AAAAABWWNWHOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBTGU4TKNRQGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the
outarray should be initiated withzeros.If not, then
outcan takenperms+1as values, and the corrective statements (out[out == nperms] = nperms - 1) apply on the wrong sample.@bruAristimunha what do you think?