-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lee] Step 3: HTTP 웹서버 구현 #4
Open
street62
wants to merge
3
commits into
Next-Squad:street62
Choose a base branch
from
street62:street62
base: street62
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResponseMaker 클래스를 통해 uri에 맞는 세부 비즈니스로직을 적용할 수 있도록 함.
Lee 하이용 재밌게 해보아용 |
nathan29849
added a commit
that referenced
this pull request
Jul 27, 2022
nathan29849
added a commit
that referenced
this pull request
Jul 27, 2022
nathan29849
added a commit
that referenced
this pull request
Jul 27, 2022
nathan29849
added a commit
that referenced
this pull request
Jul 27, 2022
Feature/#4/302 status code
ku-kim
approved these changes
Jul 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 4도 화이팅이에요 lee~~
Comment on lines
+31
to
+37
dos = new DataOutputStream(out); | ||
br = new BufferedReader(new InputStreamReader(in)); | ||
Request request = readRequest(); | ||
Response response = makeResponseOf(request); | ||
|
||
sendResponse(response); | ||
br.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메서드 단위로 로직을 구분하셨군요.!
donggi-lee-bit
added a commit
that referenced
this pull request
Aug 2, 2022
add() 메서드가 가진 여러 역할 리팩토링
jinan159
added a commit
that referenced
this pull request
Aug 7, 2022
3장 요구사항 4 - 302 status code 적용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
웹 서버 구현 PR입니다.
Commits
특정 비즈니스로직을 수행하고, 별도의 비즈니스 로직이 없을 경우에는 webapp 경로에서 해당하는 파일을 응답하도록 설계했습니다.
TODO
구현을 늦게 시작했더니 구현량이 많지 않네요 ㅠㅠ
코쿼 과정 때에는 정신없이 했던 것 같은데, 객체지향적인 구조를 생각하다 보면 꽤 고려할 게 많은 미션이라는 생각이 들었습니다.
반성하고... 다음 회차부터는 매일 조금씩 꾸준히 진행해 보려고 합니다!