[refactor] Dialog Preview 반복 되는 코드 제거 및 코드 개선 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview 에서 기존에 만들어둔 컴포저블을 호출하여 반복되는 코드 제거, ConfirmButton 의 Start Padding 이 CancelButton 이 존재할때만 적용되도록 코드 수정 @StringRes, @DrawableRes annotation 을 파라미터에 추가함으로서 코드의 안정성을 높임
easyhooon
added
the
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview 에서 기존에 만들어둔 컴포저블을 호출하여 반복되는 코드 제거,
ConfirmButton 의 Start Padding 이 CancelButton 이 존재할때만 적용되도록 코드 수정
@StringRes, @DrawableRes annotation 을 파라미터에 추가함으로서 코드의 안정성을 높임