-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Support for HTTP/3 #5296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kylhuk
wants to merge
17
commits into
NginxProxyManager:develop
Choose a base branch
from
kylhuk:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+353
−82
Open
Support for HTTP/3 #5296
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
47b367d
Merge pull request #5276 from NginxProxyManager/develop
jc21 4a85ea9
Add HTTP/3 support toggles for hosts
kylhuk 27695b3
Merge pull request #1 from kylhuk/add-http-version-selection-for-prox…
kylhuk 6c3cc83
Bump the prod-patch-updates group in /frontend with 2 updates
dependabot[bot] 678fdd2
Bump the dev-minor-updates group in /frontend with 2 updates
dependabot[bot] 40f363b
Fix uploading of custom certificates
Tech-no-1 446bfe2
Merge branch 'develop' into develop
jc21 059781f
Update zh.json
jc21 aff390f
Merge pull request #5317 from Tech-no-1/fix-custom-certificates
jc21 fc4c5aa
Merge pull request #5315 from NginxProxyManager/dependabot/npm_and_ya…
jc21 627f43c
Merge pull request #5314 from NginxProxyManager/dependabot/npm_and_ya…
jc21 c7437dd
Merge branch 'master' into develop
jc21 da9b4bf
Add HTTP/3 support toggles for hosts
kylhuk 0c397e8
Merge branch 'develop' of github.com:kylhuk/nginx-proxy-manager into …
38641bb
fix: reuseport only in default config
1457a7e
feat: logic for handling http3 config properly
8cbd413
fix: should place the HTTP2/HTTP3 buttons on one row
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import { migrate as logger } from "../logger.js"; | ||
|
|
||
| const migrateName = "http3_support"; | ||
|
|
||
| /** | ||
| * Migrate | ||
| * | ||
| * @see http://knexjs.org/#Schema | ||
| * | ||
| * @param {Object} knex | ||
| * @returns {Promise} | ||
| */ | ||
| const up = (knex) => { | ||
| logger.info(`[${migrateName}] Migrating Up...`); | ||
|
|
||
| return knex.schema | ||
| .table("proxy_host", (proxy_host) => { | ||
| proxy_host.integer("http3_support").notNull().unsigned().defaultTo(0); | ||
| }) | ||
| .then(() => { | ||
| logger.info(`[${migrateName}] proxy_host Table altered`); | ||
|
|
||
| return knex.schema.table("redirection_host", (redirection_host) => { | ||
| redirection_host.integer("http3_support").notNull().unsigned().defaultTo(0); | ||
| }); | ||
| }) | ||
| .then(() => { | ||
| logger.info(`[${migrateName}] redirection_host Table altered`); | ||
|
|
||
| return knex.schema.table("dead_host", (dead_host) => { | ||
| dead_host.integer("http3_support").notNull().unsigned().defaultTo(0); | ||
| }); | ||
| }) | ||
| .then(() => { | ||
| logger.info(`[${migrateName}] dead_host Table altered`); | ||
| }); | ||
| }; | ||
|
|
||
| /** | ||
| * Undo Migrate | ||
| * | ||
| * @param {Object} knex | ||
| * @returns {Promise} | ||
| */ | ||
| const down = (_knex) => { | ||
| logger.warn(`[${migrateName}] You can't migrate down this one.`); | ||
| return Promise.resolve(true); | ||
| }; | ||
|
|
||
| export { up, down }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logic seems correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems like a fair bug fix. The second parameter is optional, although lib does not specify where the temp file will be created. Reference: https://www.npmjs.com/package/temp-write