Rate limit error reporting #694
Open
+82
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arionrefat
commented
Mar 18, 2025
arionrefat
commented
- Added rate limiting to Sentry transport to prevent overwhelming Sentry with too many events
- Limited to 10 logs per second with 1000ms interval
- Queues additional logs when rate limit is exceeded
- Preserves all existing Sentry logging functionality including error capturing and message handling
- Added reference to Node types for setImmediate support
- Added comprehensive cleanup of podman containers, pods, and images - Implemented removal of podman configuration folders - Improved error handling during uninstallation - Restored electron app path import for home directory access
- Replace any types with proper TypeScript utility types - Add ThisParameterType, Parameters, and ReturnType generics - Create QueueItem type for better type safety in FIFO queue
✅ Deploy Preview for nndesign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
arionrefat
changed the title
|
@jgresham This is what I implemented, can you please check if I doing it properly? |
- Renamed rateLimitedLog to normalLogRateLimiter for clarity - Updated logging logic to bypass rate limiting for errors and fatal logs - Ensured normal messages are still subject to rate limiting
- Included a comment attributing the original source of the rate limiting code - Added MIT License notice for clarity and compliance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.