Skip to content

Conversation

@devkav
Copy link

@devkav devkav commented Feb 20, 2024

Description
There are currently some inconsistencies with dragon highlight colors. This effects users with more than 100 wins. Anytime the user opens the game in a new tab, dragon cards will be highlighted green whenever they hover over the "Move Dragons" button. However, if they successfully move all dragons of a given color, then that color dragon will be highlighted white for the rest of their games.

Steps to Reproduce

  1. Open shenzhen solitaire in a new tab. Ensure you have more than 100 wins by updating shenzhen_win_count value in local storage.
  2. Hover your cursor over the "Move Dragons" buttons. Notice that they all are highlighted green
  3. Clear all of the dragons of a given color
  4. Start a new game in the same tab
  5. Hover your cursor over the "Move Dragons" buttons. Notice that the dragons you cleared in the previous game now highlight white, whereas the other colors are still highlighted green.

Solution
This was caused by unclear css rules and the grand_dragon css class not being removed between games. I'm assuming that grand dragons should only be highlighted in white when they are flipped over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant