Rules based on current race #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional popup window warning about possible infinite loops before Cond_Race is enabled.
|
Review changes with Changed Files
|
Collaborator
|
Thank you, I'll hold this for a bit because I want to make sure infinite loops can't happen, one way or another |
Collaborator
|
Hello! Please keep it open, the PR will be merged after I can figure out how to prevent infinite loops |
Contributor
Author
|
yeah sorry i accidentally deleted the branch while deleting the other old ones! trying to figure out how to make the conflicts resolve! Didn't know how to open it again! Still learning collaborative git. |
Contributor
Author
|
Assuming this change works, this should finally resolve Limiana/DynamicBridgeStandalone#32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watch for infinite loops... :| its super easy for glamourer to loop you, but also really easy to "stop" the loop but just disabling the rules 1 by one. No different than spam changing outfits. Doesn't actually get caught in an infinite loop in code. Only when you a loop is finished, it updates your looks (changing your race), then the rules get updated etc etc....
There's an extra window pop-up warning of this, and requiring users to "yield right to complain"