Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 14, 2019

Purpose of this PR

  • Rewritten the Symbol Transformation based on what described in humanizer extension method
  • SymbolTransformer.cs and AdvancedDLSupport.csproj files are affected

Testing status

  • All Tests Passed without problem!

@ghost
Copy link
Author

ghost commented Oct 14, 2019

Ok, added few tests to verify the implementations and the behavior matches that of Humanizer.

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #95 into master will increase coverage by 0.25%.
The diff coverage is 98.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   88.88%   89.13%   +0.25%     
==========================================
  Files         115      118       +3     
  Lines        5642     5717      +75     
  Branches      497      513      +16     
==========================================
+ Hits         5015     5096      +81     
+ Misses        616      610       -6     
  Partials       11       11
Impacted Files Coverage Δ
...ts/Tests/Integration/SymbolTransformationTests3.cs 100% <100%> (ø)
...ts/Tests/Integration/SymbolTransformationTests4.cs 100% <100%> (ø)
...ts/Tests/Integration/SymbolTransformationTests2.cs 100% <100%> (ø)
...LSupport/SymbolTransformation/SymbolTransformer.cs 83.15% <98.24%> (+33.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca64b5b...b5351f6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants