Skip to content

Commit

Permalink
Allow DBG=1 to be used with make release-images and make quick-releas…
Browse files Browse the repository at this point in the history
…e-images
  • Loading branch information
brianpursley committed Nov 1, 2022
1 parent 526650f commit 8a1b480
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion build/release-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ fi

kube::build::verify_prereqs
kube::build::build_image
kube::build::run_build_command make all WHAT="${CMD_TARGETS}" KUBE_BUILD_PLATFORMS="${KUBE_SERVER_PLATFORMS[*]}"
kube::build::run_build_command make all WHAT="${CMD_TARGETS}" KUBE_BUILD_PLATFORMS="${KUBE_SERVER_PLATFORMS[*]}" DBG="${DBG:-}"

kube::build::copy_output

Expand Down
10 changes: 10 additions & 0 deletions build/root/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,14 @@ define RELEASE_IMAGES_HELP_INFO
#
# Args:
# KUBE_BUILD_CONFORMANCE: Whether to build conformance testing image as well. Set to 'n' to skip.
# DBG: If set to "1", build with optimizations disabled for easier debugging. Any other value is ignored.
#
# Example:
# make release-images
# make release-images DBG=1
# Note: Specify DBG=1 for building unstripped binaries, which allows you to use code debugging
# tools like delve. When DBG is unspecified, it defaults to "-s -w" which strips debug
# information.
endef
.PHONY: release-images
ifeq ($(PRINT_HELP),y)
Expand Down Expand Up @@ -405,9 +410,14 @@ define QUICK_RELEASE_IMAGES_HELP_INFO
# Args:
# KUBE_FASTBUILD: Whether to cross-compile for other architectures. Set to 'false' to do so.
# KUBE_BUILD_CONFORMANCE: Whether to build conformance testing image as well. Set to 'y' to do so.
# DBG: If set to "1", build with optimizations disabled for easier debugging. Any other value is ignored.
#
# Example:
# make quick-release-images
# make quick-release-images DBG=1
# Note: Specify DBG=1 for building unstripped binaries, which allows you to use code debugging
# tools like delve. When DBG is unspecified, it defaults to "-s -w" which strips debug
# information.
endef
.PHONY: quick-release-images
ifeq ($(PRINT_HELP),y)
Expand Down

0 comments on commit 8a1b480

Please sign in to comment.