treewide: apply statix suggestions

vcunat's comments:
 - taken from PR #374
 - I really like these, sad not to use them for so long
 - very minimal/safe

build/flake.nix

@@ -87,7 +87,7 @@
           deployment = {
             targetHost = "${name}.nixos.org";
           };
-        }) (self.nixosConfigurations);
+        }) self.nixosConfigurations;
 
       # TODO: flake-utils.lib.eachDefaultSystem
       devShell.x86_64-linux = let

build/hydra-scaler.nix

@@ -8,7 +8,7 @@
     secretFile = "/root/keys/hydra-scale-equinix-metal-env";
     interval = ["*:0/5"];
     config = let
-      netboot_base = https://netboot.nixos.org/dispatch/hydra/hydra.nixos.org/equinix-metal-builders/main;
+      netboot_base = "https://netboot.nixos.org/dispatch/hydra/hydra.nixos.org/equinix-metal-builders/main";
     in {
       metro = "any";
       tags = ["hydra"];

channels.nix

@@ -88,5 +88,5 @@ rec {
     };
   };
 
-  channels-with-urls = (builtins.mapAttrs (name: about: about.job) channels);
+  channels-with-urls = builtins.mapAttrs (name: about: about.job) channels;
 }

macs/nix-darwin.nix

@@ -55,9 +55,9 @@ in
   '';
 
   environment.etc."per-user/root/ssh/authorized_keys".text = concatStringsSep "\n"
-    ([
+    [
       (authorizedNixStoreKey sshKeys.hydra-queue-runner)
-    ]);
+    ];
 
 
   system.activationScripts.postActivation.text = ''

non-critical-infra/flake.nix

@@ -40,13 +40,13 @@
   outputs = { self, nixpkgs, flake-utils, colmena, disko, srvos, first-time-contribution-tagger, sops-nix, ... }@inputs:
     let
       importConfig = path: (lib.mapAttrs (name: value: import (path + "/${name}/default.nix")) (lib.filterAttrs (_: v: v == "directory") (builtins.readDir path)));
-      lib = nixpkgs.lib;
+      inherit (nixpkgs) lib;
     in
     {
 
       nixosConfigurations = builtins.mapAttrs
         (name: value: nixpkgs.lib.nixosSystem {
-          lib = lib;
+          inherit lib;
           system = "x86_64-linux";
           specialArgs = {
             inherit inputs;

non-critical-infra/modules/postfix.nix

@@ -10,18 +10,18 @@
     enable = true;
     domains = config.networking.fqdn;
     selector = "mail";
-    user = config.services.postfix.user;
-    group = config.services.postfix.group;
+    inherit (config.services.postfix)
+      user
+      group
+    ;
     keyPath = "/run/opendkim-keys";
   };
 
   systemd.services.opendkim.serviceConfig = {
     ExecStartPre = [
-      (
-        "+${pkgs.writeShellScript "opendkim-keys" ''
-          install -o ${config.services.postfix.user} -g ${config.services.postfix.group} -D -m0700 ${config.sops.secrets.opendkim-private-key.path} /run/opendkim-keys/${config.services.opendkim.selector}.private
-        ''}"
-      )
+      "+${pkgs.writeShellScript "opendkim-keys" ''
+        install -o ${config.services.postfix.user} -g ${config.services.postfix.group} -D -m0700 ${config.sops.secrets.opendkim-private-key.path} /run/opendkim-keys/${config.services.opendkim.selector}.private
+      ''}"
     ];
   };