Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macs: add apple-virt, nixos-test system features #431

Closed
wants to merge 2 commits into from

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented May 24, 2024

No description provided.

@cole-h cole-h requested a review from vcunat May 24, 2024 16:42
@cole-h cole-h requested a review from a team as a code owner May 24, 2024 16:42
macs/nix-darwin.nix Outdated Show resolved Hide resolved
@mweinelt
Copy link
Member

I think this was tested, and you discussed it in the infra room, but I missed the outcome. Can someone bring me up to speed?

@cole-h
Copy link
Member Author

cole-h commented May 30, 2024

It was applied to one machine (cosmic-stud) and it "worked" in that they weren't being cancelled / aborted / whatever'd anymore, but the tests taking advantage of this would just hang (c.f. NixOS/nixpkgs#303597 (comment) and NixOS/nixpkgs#303597 (comment))

@vcunat
Copy link
Member

vcunat commented May 30, 2024

As it was always hanging, I rolled back the rhea's machines file, so that scheduler wouldn't try to run these jobs.

@Mic92
Copy link
Member

Mic92 commented Sep 23, 2024

Is this good to merge?

@vcunat
Copy link
Member

vcunat commented Sep 23, 2024

Running those jobs doesn't seem to work. They hang and time out. (I observed it several days ago again.)

@cole-h
Copy link
Member Author

cole-h commented Oct 23, 2024

Closing. Feel free to reopen if we want to spend time figuring out why they're hanging.

@cole-h cole-h closed this Oct 23, 2024
@cole-h cole-h deleted the add-virt-feature branch October 23, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants