nix-daemon: source nix-profile-daemon.sh only once #12805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my system (Ubuntu 24.04 with nix installed using https://zero-to-nix.com/), I noticed that my PATH contained multiple times the following entries: /home/thomas/.nix-profile/bin /nix/var/nix/profiles/default/bin Fix it by inserting a missing `export`, to make sure `nix-daemon.sh` is really only executed once.
tomberek
approved these changes
Mar 31, 2025
|
Wow, this has been a bug the whole time? 6a037a7 |
Mic92
added
backport 2.24-maintenance
|
Any possibility that this bug has now been ossified and depended on somewhere critical? NixOS? |
|
I think it's the other way around, because we have other mechanisms in NixOS, it would never source this file twice. |
This was referenced Apr 1, 2025
mergify bot
added a commit
that referenced
this pull request
Apr 1, 2025
…2805 nix-daemon: source nix-profile-daemon.sh only once (backport #12805)
mergify bot
added a commit
that referenced
this pull request
Apr 1, 2025
…2805 nix-daemon: source nix-profile-daemon.sh only once (backport #12805)
mergify bot
added a commit
that referenced
this pull request
Apr 1, 2025
…2805 nix-daemon: source nix-profile-daemon.sh only once (backport #12805)
mergify bot
added a commit
that referenced
this pull request
Apr 1, 2025
…2805 nix-daemon: source nix-profile-daemon.sh only once (backport #12805)
mergify bot
added a commit
that referenced
this pull request
Apr 1, 2025
…2805 nix-daemon: source nix-profile-daemon.sh only once (backport #12805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On my system (Ubuntu 24.04 with nix installed using https://zero-to-nix.com/), I noticed that my PATH contained multiple times the following entries:
Fix it by inserting a missing
exportinnix-daemon.sh, so that it really gets executed only once.Context
Related: #5950.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.