Use direct PATH manipulation to avoid conflicts with user's fish_user_paths
#14691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current
nix-profile{,-daemon}.fishsetsfish_user_pathsas a global variable, which shadows theuser's universal
fish_user_paths, causing paths added viafish_add_pathnot to persist acrosssessions as many users expect.
Context
This is the same issue that affected asdf:
The fix directly manipulates
$PATHinstead of usingfish_user_paths, as noted inasdf-vm/asdf#1709:
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to
schedule and track reviews.