Skip to content

Conversation

@abap34
Copy link

@abap34 abap34 commented Dec 2, 2025

Motivation

The current nix-profile{,-daemon}.fish sets fish_user_paths as a global variable, which shadows the
user's universal fish_user_paths, causing paths added via fish_add_path not to persist across
sessions as many users expect.

Context

This is the same issue that affected asdf:

The fix directly manipulates $PATH instead of using fish_user_paths, as noted in
asdf-vm/asdf#1709:

avoids assumptions about $fish_user_paths being global or universal, which should be the shell user's
decision. Note that in fish $PATH cannot be a universal variable (it's simply inherited from the
parent process), so it does not have this issue.


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to
schedule and track reviews.

@abap34 abap34 requested a review from edolstra as a code owner December 2, 2025 13:38
@abap34
Copy link
Author

abap34 commented Dec 24, 2025

Hi @edolstra! Thank you for your daily work. Could you review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant