libutil: remove regex from fixGitURL scp and improve colon handling #14866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaczero
changed the title
Zaczero
force-pushed
the
zaczero/convinced-rat
branch
from
3b79372 to
ed01333
Compare
Copilot AI
added a commit
to Zaczero/nix
that referenced
this pull request
Dec 26, 2025
This document analyzes all pointer and index accesses in the rewriteScpLikeGitURL function from PR NixOS#14866. All accesses are verified to be safe with proper bounds checking. Key findings: - All 4 pointer/index accesses have proper bounds checking - Uses short-circuit evaluation to prevent unsafe access - Comprehensive edge case handling - Extensive test coverage included in PR Conclusion: All pointer accesses are SAFE. Co-authored-by: Zaczero <[email protected]>
Contributor
|
There's also #14863, fixGitURL has some issues, as outlined in the comments on that PR. Would make sense to land the fixes together. |
Member
Author
|
I could merge the tests and new features (accept paths without a user component) if that's the right direction. Then I could try to write it regex-less. Is that what we want here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed heavy scpRegex instantiation per fixGitURL call and reimplemented in a way that is more correct about colon handling, fixing potential IPv6 and other issues.
Previous implementation would rewrite:
"user@host:a:b"
into "ssh://user@host:a/b"
instead of "ssh://user@host/a:b"
"user@[2001:db8:1::2]:a:b"
into "ssh://user@[2001:db8:1::2]:a/b"
instead of "ssh://user@[2001:db8:1::2]/a:b"
This change should make fixGitURL more efficient and correctish.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.