Skip to content

orange-pi-5-max: init #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

orange-pi-5-max: init #1409

wants to merge 1 commit into from

Conversation

vlinkz
Copy link
Member

@vlinkz vlinkz commented Mar 12, 2025

Description of changes

Added orange-pi-5-max

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@vlinkz vlinkz requested a review from Mic92 March 12, 2025 21:48
# fetched from https://github.com/armbian/build/blob/v24.11.1/config/kernel/linux-rk35xx-vendor.config
configfile = ./linux-rk35xx-vendor.config;
# converted to nix using https://github.com/NixOS/nixpkgs/blob/79aaddff29307748c351a13d66f9d1fba4218624/pkgs/os-specific/linux/kernel/manual-config.nix#L11-L19
config = import ./linux-rk35xx-vendor.nix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate that NixOS requires these settings to be present to. Merging this pull request would double the size of this repository in terms of lines of code. On the one hand it would be great to have this kernel in but on the other it adds quite a bit of weight. Do you know where we use this information in NixOS?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would happen if we provide the config of a similar kernel version? Is this just about safety checks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did test without these configs set, but I get failed kernel builds. But looks like since I made this pr kernel 6.14 is now the latest in nixos-unstable and has mainline support for orangepi 5 max. Going to test if we can just use latest mainline instead 👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make it a lot more usable for everyone.

@JRodez
Copy link

JRodez commented Apr 24, 2025

Hi,
What features are covered by this PR ?

@vlinkz
Copy link
Member Author

vlinkz commented Apr 25, 2025

Hi,
What features are covered by this PR ?

Pretty much everything supported by the base Ubuntu Image:

  • u-boot
  • configurable uart
  • graphics drivers
  • audio
  • wifi/bluetooth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants