-
-
Notifications
You must be signed in to change notification settings - Fork 740
orange-pi-5-max: init #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
orange-pi-5-max: init #1409
Conversation
# fetched from https://github.com/armbian/build/blob/v24.11.1/config/kernel/linux-rk35xx-vendor.config | ||
configfile = ./linux-rk35xx-vendor.config; | ||
# converted to nix using https://github.com/NixOS/nixpkgs/blob/79aaddff29307748c351a13d66f9d1fba4218624/pkgs/os-specific/linux/kernel/manual-config.nix#L11-L19 | ||
config = import ./linux-rk35xx-vendor.nix; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit unfortunate that NixOS requires these settings to be present to. Merging this pull request would double the size of this repository in terms of lines of code. On the one hand it would be great to have this kernel in but on the other it adds quite a bit of weight. Do you know where we use this information in NixOS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would happen if we provide the config of a similar kernel version? Is this just about safety checks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did test without these configs set, but I get failed kernel builds. But looks like since I made this pr kernel 6.14 is now the latest in nixos-unstable and has mainline support for orangepi 5 max. Going to test if we can just use latest mainline instead 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would make it a lot more usable for everyone.
Hi, |
Pretty much everything supported by the base Ubuntu Image:
|
Description of changes
Added
orange-pi-5-max
Things done
nixos-hardware
andimporting it via
<nixos-hardware>
or Flake input